Skip to content

Refactor getAllDescendants to use iterative worklist #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msaadsbr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor getAllDescendants to use iterative worklist #5564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Proposals.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,13 +474,15 @@ proposalsRemoveWithDescendants gais ps@(Proposals omap _roots graph) =
getAllDescendants gai =
case OMap.lookup gai omap of
Nothing -> assert False mempty
Just gas -> withGovActionParent gas mempty $ \govRelationL _ ->
let go acc gpi =
case Map.lookup gpi $ graph ^. govRelationL . pGraphNodesL of
Nothing -> assert False acc
Just (PEdges _parent children) ->
F.foldl' go (Set.map unGovPurposeId children <> acc) children
in go mempty
Just gas -> withGovActionParent gas mempty $ \govRelationL _ selfId ->
let loop !acc [] = acc
loop !acc (curr : rest) =
case Map.lookup curr $ graph ^. govRelationL . pGraphNodesL of
Nothing -> loop acc rest
Copy link
Contributor

@teodanciu teodanciu Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diverges from the original implementation which does assert False.

Just (PEdges _ children) ->
let newChildren = Set.map unGovPurposeId children
in loop (newChildren <> acc) (Set.toList children ++ rest)
in loop mempty [selfId]
Copy link
Contributor

@teodanciu teodanciu Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does adding the govPurposeId to the accumulator preserve the original logic? I can't convince myself of it.

Copy link
Collaborator

@lehins lehins Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a property test that tests that the new approach matches the semantics of the old one. It will serve as a good regression tests going into the future as well.


-- | For use in the @`EPOCH`@ rule. Apply the result of
-- @`extractDRepPulsingState`@ to the @`Proposals`@ forest, so that:
Expand Down