Support Plutus V4 CBOR tag in AlonzoScript decoder #5567
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you please also update the non-Annotator version of the decoder? https://github.com/IntersectMBO/cardano-ledger/blob/master/eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Binary/Annotator.hs#L300 Also, it would be good to have a more descriptive commit message like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The encoder for AlonzoScript uses tag 4 for Plutus V4, but the decoder did not handle tag 4, which can cause valid Plutus V4 scripts to be rejected when decoding.
Description
Add 4 -> decodeAnnPlutus SPlutusV4 to the decodeScript function in eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs so decoding matches the encoder's tags.
Testing
No automated tests were run for this trivial decoder fix.