Conversation
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
from
6539d8a to
110ecf8
Compare
neilmayhew
approved these changes
Mar 20, 2026
Contributor
neilmayhew
left a comment
neilmayhew
left a comment
There was a problem hiding this comment.
Looks good! I tested it locally and it works well. Thanks for doing this.
We should also consider enabling other tools in pre-commit. In cardano-ledger-release-tool I also have nixpkgs-fmt, shellcheck and hlint enabled.
lehins
approved these changes
Mar 20, 2026
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
from
110ecf8 to
2cfe8d0
Compare
koslambrou
changed the title
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
2 times, most recently
from
006e46e to
f9a5f71
Compare
neilmayhew
requested changes
Mar 20, 2026
Contributor
neilmayhew
left a comment
neilmayhew
left a comment
There was a problem hiding this comment.
Looks great! Only one small change needed.
I'm glad to see our nix formatting cleaned up, especially since it was done inconsistently in different time periods. I've been wanting someone to do this for a while.
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
from
f9a5f71 to
9a06606
Compare
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
from
9a06606 to
dda0462
Compare
…ur Nix devShell. Using `pre-commit run --all-files` will now run `fourmolu`, `cabal-gild` and `shellcheck` on all modified files. Did not add `hlint` for now because there are *lots* of warnings that will take time to fix.
koslambrou
force-pushed
the
koslambrou/add-cabal-gild-pre-commit-hook-nix
branch
from
dda0462 to
7c24652
Compare
koslambrou
changed the title
neilmayhew
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using
pre-commit run --all-fileswill now runcabal-gild(as well asfourmolu) on all modified files.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).