Add ToJSON/FromJSON instances for NonEmptyMap and NonEmptySet#5655
Merged
Add ToJSON/FromJSON instances for NonEmptyMap and NonEmptySet#5655
NonEmptyMap and NonEmptySet#5655Conversation
koslambrou
force-pushed
the
5650-nonemptymapset-need-tofromjson
branch
from
76e7c05 to
f74f04d
Compare
koslambrou
commented
Mar 19, 2026
koslambrou
commented
Mar 19, 2026
koslambrou
force-pushed
the
5650-nonemptymapset-need-tofromjson
branch
2 times, most recently
from
67c634c to
5ab2af3
Compare
lehins
approved these changes
Mar 20, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
That's very nice. Thank you!
Needs a fouromlu, otherwise it is good to go
koslambrou
force-pushed
the
5650-nonemptymapset-need-tofromjson
branch
2 times, most recently
from
6078d88 to
afa217e
Compare
lehins
force-pushed
the
5650-nonemptymapset-need-tofromjson
branch
from
afa217e to
9ecde04
Compare
Added the following tests:
* JSON roundtrip property test
* Unit test for trying to decode an empty object `{}` for the
`NonEmptyMap`, and an empty list `[]` for the `NonEmptySet`. These
scenarios are expected to fail with a specific error message.
koslambrou
force-pushed
the
5650-nonemptymapset-need-tofromjson
branch
from
9ecde04 to
a4ae5ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the following tests:
{}for theNonEmptyMap, and an empty list[]for theNonEmptySet. These scenarios are expected to fail with a specific error message.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).