feat: use relative paths

Author: mkoura

cardano_node_tests/testnet_cleanup_info.py

@@ -22,7 +22,7 @@ def get_args() -> argparse.Namespace:
         "-a",
         "--artifacts-base-dir",
         required=True,
-        type=helpers.check_dir_arg,
+        type=helpers.check_dir_arg_keep,
         help="Path to a directory with testing artifacts",
     )
     return parser.parse_args()
@@ -42,7 +42,7 @@ def main() -> int:
 
     state_dir = pl.Path(socket_env).parent
     cluster_obj = clusterlib.ClusterLib(state_dir=state_dir)
-    location = pl.Path(args.artifacts_base_dir).expanduser().resolve()
+    location = args.artifacts_base_dir
     balance, rewards = testnet_cleanup.addresses_info(cluster_obj=cluster_obj, location=location)
     LOGGER.info(f"Uncleaned balance: {balance} Lovelace ({balance / 1_000_000} ADA)")
     LOGGER.info(f"Uncleaned rewards: {rewards} Lovelace ({balance / 1_000_000} ADA)")

cardano_node_tests/utils/helpers.py

@@ -221,6 +221,23 @@ def check_dir_arg(dir_path: str) -> pl.Path | None:
     return abs_path
 
 
+def check_dir_arg_keep(dir_path: str) -> pl.Path | None:
+    """Check that the dir passed as argparse parameter is a valid existing dir.
+
+    Keep the original path instead resolving it to absolute.
+    """
+    if not dir_path:
+        return None
+    orig_path = pl.Path(dir_path)
+    abs_path = orig_path.expanduser().resolve()
+    if not (abs_path.exists() and abs_path.is_dir()):
+        msg = f"check_dir_arg: directory '{dir_path}' doesn't exist"
+        raise argparse.ArgumentTypeError(msg)
+    if dir_path.startswith("~"):
+        orig_path.expanduser()
+    return orig_path
+
+
 def check_file_arg(file_path: str) -> pl.Path | None:
     """Check that the file passed as argparse parameter is a valid existing file."""
     if not file_path: