Skip to content

Add SMASH service support for testing#2909

Merged
mkoura merged 4 commits intomasterfrom
artur/add-smash
Mar 18, 2025
Merged

Add SMASH service support for testing#2909
mkoura merged 4 commits intomasterfrom
artur/add-smash

Conversation

@ArturWieczorek
Copy link
Collaborator

No description provided.

@ArturWieczorek ArturWieczorek force-pushed the artur/add-smash branch 26 times, most recently from 5b06bf2 to 78e9797 Compare February 26, 2025 17:30
@ArturWieczorek ArturWieczorek force-pushed the artur/add-smash branch 2 times, most recently from d4e6316 to 2a587fe Compare March 12, 2025 11:41
@ArturWieczorek ArturWieczorek marked this pull request as ready for review March 12, 2025 12:19
@ArturWieczorek
Copy link
Collaborator Author

@mkoura I pushed an update to address review suggestions.

mkoura and others added 3 commits March 14, 2025 18:08
- Added symbolic links for SMASH server binaries in `source_dbsync.sh`
- Exported `PGPASSFILE` in `run-cardano-smash` script - it is needed in
  the end
- Updated `test_pools.py` and `test_smash.py` to use keyword arguments
- Added docstrings to test methods in `test_smash.py`
- Added module level qualified imports
- Fixed a fixture that cannot be session scoped
Copy link
Collaborator

@mkoura mkoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 🚀

@mkoura mkoura merged commit 9f48726 into master Mar 18, 2025
3 checks passed
@mkoura mkoura deleted the artur/add-smash branch March 18, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants