Build method test native tokens #3121
Conversation
| witness_count_add=len(tx_files.signing_key_files), | ||
| ) | ||
| else: | ||
| pytest.skip(f"Unsupported build method: {build_method}") |
There was a problem hiding this comment.
Raise exception instead of skipping when calling with invalid build method.
| cluster.g_transaction.submit_tx(tx_file=tx_signed, txins=tx_raw_output.txins) | ||
|
|
||
| else: | ||
| pytest.skip(f"Unsupported build method: {build_method}") |
There was a problem hiding this comment.
Raise exception instead of skipping when calling with invalid build method.
| cluster.g_transaction.submit_tx(tx_file=tx_signed, txins=tx_raw_output.txins) | ||
|
|
||
| else: | ||
| pytest.skip(f"Unsupported build method: {build_method}") |
There was a problem hiding this comment.
Raise exception instead of skipping when calling with invalid build method.
| txouts=txouts, | ||
| tx_files=tx_files, | ||
| ) | ||
| assert expected_error in str(excinfo.value) |
There was a problem hiding this comment.
Raise exception when calling with invalid build method.
| "The transaction does not balance in its use of assets" in exc_val | ||
| or "ValueNotConservedUTxO" in exc_val | ||
| ), exc_val | ||
|
|
There was a problem hiding this comment.
Raise exception when calling with invalid build method.
| logging.disable(logging.NOTSET) | ||
|
|
||
| exc_val = str(excinfo.value) | ||
| # build-estimate tends to throw balancing errors |
There was a problem hiding this comment.
At this point we don't know how the error message looks like, because we are likely hitting the cli issue 1199. Let the test fail with a TODO comment, so we know what to do once the issue is fixed.
| invalid_hereafter=invalid_hereafter, | ||
| invalid_before=invalid_before, | ||
| witness_count_add=len(tx_files.signing_key_files), | ||
| ) |
There was a problem hiding this comment.
Raise exception when calling with invalid build method.
This PR continues the cleanup of transaction building across the codebase by fully deprecating
use_build_cmdin minting, burning, and token transfer flows. All affected tests and utility functions now rely on thebuild_methodparameter, supporting multiple build paths (BUILD,BUILD_RAW,BUILD_EST) in a unified way.Key Changes
Tests
Minting & Burning Tests
test_minting_and_burning_witnesses,test_minting_and_burning_sign,test_minting_multiple_scripts,test_minting_burning_diff_tokens_single_tx,test_minting_burning_same_token_single_tx,test_bundle_minting_and_burning_*,test_minting_and_partial_burning,test_minting_unicode_asset_nameto replaceuse_build_cmdwithbuild_method.expected_fee) to depend onbuild_methodinstead of a boolean flag.BUILD_EST(build-estimate) where relevant.Policy Tests
test_valid_policy_afterandtest_valid_policy_beforeto followbuild_method.Transfer Tests
test_transfer_tokens,test_transfer_multiple_tokens,test_transfer_no_ada, andtest_transfer_invalid_token_amountto replaceuse_build_cmdwithbuild_method.BUILD_ESTalongside existing build methods.Reference Script Tests
test_script_reference_utxoto branch bybuild_methodinstead ofuse_build_cmd.BUILD_EST.Committee Tests
test_register_hot_key_no_cc_memberandtest_update_committee_actionintests_conway/test_committee.pyto removeuse_build_cmdin favor ofbuild_method.Utilities (
clusterlib_utils.py)mint_or_burn_witnessandmint_or_burn_signuse_build_cmdparameter withbuild_method.BUILD,BUILD_RAW, andBUILD_EST.