refactor(utils): use shared http_client for requests#3242
Merged
Conversation
Replaces direct usage of the requests library with the shared http_client session in dbsync_snapshot_service and smash_utils. This improves consistency and enables centralized configuration for HTTP requests.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors HTTP request handling to use a shared HTTP client session instead of direct requests library calls. This improves consistency across the codebase and enables centralized HTTP configuration.
- Replaced
requests.get()calls withhttp_client.get_session().get()in two utility modules - Removed unnecessary
requestsimport indbsync_snapshot_service.py - Maintained all existing request parameters and authentication mechanisms
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cardano_node_tests/utils/smash_utils.py |
Updated get_retired_pools() method to use shared HTTP client session, consistent with other methods in the class |
cardano_node_tests/utils/dbsync_snapshot_service.py |
Replaced direct requests import and usage with shared http_client module in S3 API calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces direct usage of the requests library with the shared http_client session in dbsync_snapshot_service and smash_utils. This improves consistency and enables centralized configuration for HTTP requests.