Skip to content

refactor(utils): use shared http_client for requests#3242

Merged
mkoura merged 1 commit intomasterfrom
use_http_client
Dec 2, 2025
Merged

refactor(utils): use shared http_client for requests#3242
mkoura merged 1 commit intomasterfrom
use_http_client

Conversation

@mkoura
Copy link
Collaborator

@mkoura mkoura commented Dec 2, 2025

Replaces direct usage of the requests library with the shared http_client session in dbsync_snapshot_service and smash_utils. This improves consistency and enables centralized configuration for HTTP requests.

Replaces direct usage of the requests library with the shared http_client
session in dbsync_snapshot_service and smash_utils. This improves
consistency and enables centralized configuration for HTTP requests.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors HTTP request handling to use a shared HTTP client session instead of direct requests library calls. This improves consistency across the codebase and enables centralized HTTP configuration.

  • Replaced requests.get() calls with http_client.get_session().get() in two utility modules
  • Removed unnecessary requests import in dbsync_snapshot_service.py
  • Maintained all existing request parameters and authentication mechanisms

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cardano_node_tests/utils/smash_utils.py Updated get_retired_pools() method to use shared HTTP client session, consistent with other methods in the class
cardano_node_tests/utils/dbsync_snapshot_service.py Replaced direct requests import and usage with shared http_client module in S3 API calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@mkoura mkoura merged commit 8f8501c into master Dec 2, 2025
9 checks passed
@mkoura mkoura deleted the use_http_client branch December 2, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments