Skip to content

Conversation

@ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Jan 8, 2024

Enable the flake output building a "binary release" of cardano-node and other binaries also on aarch64-darwin builds.

We use this downstream to build cardano-node and cardano-cli distributable executables for our users. See also cardano-scaling/hydra#1233

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. -> Not needed
  • Any changes are noted in the CHANGELOG.md for affected package. -> Not needed
  • The version bounds in .cabal files are updated -> Not needed
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@ch1bo ch1bo requested review from a team March 1, 2024 13:33
@github-actions github-actions bot removed the Stale label Mar 2, 2024
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR. There are hydra failures, which may be fixed on master already.

@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from 3e47920 to bd31f80 Compare March 19, 2024 17:36
@ch1bo ch1bo requested a review from a team March 19, 2024 17:36
@ch1bo ch1bo requested a review from a team as a code owner March 19, 2024 17:36
@github-actions
Copy link

github-actions bot commented May 4, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 4, 2024
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@github-actions github-actions bot removed the Stale label May 5, 2024
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from bd31f80 to eae4325 Compare May 23, 2024 10:35
@ch1bo ch1bo enabled auto-merge May 23, 2024 10:36
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from eae4325 to 9b91e8a Compare June 12, 2024 11:00
@github-actions
Copy link

github-actions bot commented Jul 6, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jul 6, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Sep 7, 2025
auto-merge was automatically disabled September 7, 2025 02:06

Pull request was closed

@ch1bo
Copy link
Contributor Author

ch1bo commented Nov 7, 2025

Revived this with the aim of also including aarch64-linux after a slack conversation

@ch1bo ch1bo reopened this Nov 7, 2025
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from 9b91e8a to 776a402 Compare November 7, 2025 14:04
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@github-actions github-actions bot removed the Stale label Nov 9, 2025
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from 776a402 to 755c97a Compare December 1, 2025 08:20
@ch1bo ch1bo enabled auto-merge December 1, 2025 08:21
@ch1bo ch1bo disabled auto-merge December 1, 2025 08:21
@ch1bo ch1bo force-pushed the cardano-node-macos-for-aarch64-darwin branch from 755c97a to 2b53276 Compare December 1, 2025 08:22
@ch1bo ch1bo enabled auto-merge December 1, 2025 08:22
@ch1bo ch1bo added this pull request to the merge queue Dec 1, 2025
Merged via the queue into IntersectMBO:master with commit eb8407f Dec 1, 2025
22 checks passed
@ch1bo ch1bo deleted the cardano-node-macos-for-aarch64-darwin branch December 1, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants