Skip to content

Conversation

@johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Nov 22, 2024

Description

  • Ensures legacy tracing is default via config when the node default itself changes to new tracing system
  • Fixes default OCI mainnet topology p2p json
  • Updates some OCI legacy cmds and repo references

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Required CI passes
  • Self-reviewed the diff

@johnalotoski johnalotoski requested a review from a team November 22, 2024 16:11
@johnalotoski johnalotoski requested a review from a team as a code owner November 22, 2024 16:11
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @johnalotoski

@mgmeier mgmeier added this pull request to the merge queue Nov 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 25, 2024
@mgmeier mgmeier added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit ef5f0a9 Nov 25, 2024
24 checks passed
@mgmeier mgmeier deleted the jl/legacy-tracing-and-oci-update branch November 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants