Skip to content

Conversation

@smelc
Copy link
Contributor

@smelc smelc commented Nov 29, 2024

Description

Command to launch the propose and ratify new constitution was outdated. This PR updates it.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

How to trust this PR

  1. It solely changes a comment
  2. Try the previous stanza: DISABLE_RETRIES=1 cabal test cardano-testnet-test --test-options '-p "/ProposeAndRatifyNewConstitution/"'
  3. Observe it runs 0 tests
  4. Try the new stanza: DISABLE_RETRIES=1 cabal test cardano-testnet-test --test-options '-p "/Propose And Ratify New Constitution/"'
  5. Observe the expected test is launched

@smelc smelc marked this pull request as ready for review November 29, 2024 16:26
@smelc smelc requested a review from a team as a code owner November 29, 2024 16:26
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out with

, ignoreOnMacAndWindows "Propose And Ratify New Constitution" Gov.hprop_ledger_events_propose_new_constitution

@smelc smelc added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 2, 2024
@smelc smelc added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit f3978c3 Dec 2, 2024
23 checks passed
@smelc smelc deleted the smelc/fix-launching-test-stanza branch December 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants