-
Notifications
You must be signed in to change notification settings - Fork 749
Network tracing instances for fetch decisions #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHaP bump for node 10.1.3
* ConsensusMode * MinBigLedgerPeersForTrustedState
- Categorise `LedgerDB.SnapshotMissingChecksum` trace as `Warning` - Expose snapshot checksum switch in config file
Co-authored-by: Marcin Szamotulski <[email protected]>
…create-testnet-data changes
Fix some tracing instances
* Provide instances for `FetchDecisionEvent` for new tracing system. * Provide `ToJSON` instances for `FetchDecision` (via `FetchDecisionToJSON` newtype wrapper), `TraceDecisionEvent`, `Point` which can be used by both new and old tracing system. * Provide `Verbose` newtype wrapper wich `ToJSON` instances provide more verbose output.
34482ed to
4f0c873
Compare
73b722d to
eda80ed
Compare
a9cf93a to
d59cf4b
Compare
0124e36 to
91cf3f1
Compare
|
This PR is stale because it has been open 45 days with no activity. |
Contributor
Author
|
The changes were merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FetchDecisionEventfor new tracingsystem.
ToJSONinstances forFetchDecision(viaFetchDecisionToJSONnewtype wrapper),TraceDecisionEvent,Pointwhich can be used by both new and old tracing system.
Verbosenewtype wrapper wichToJSONinstances provide moreverbose output.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.