Skip to content

Conversation

@coot
Copy link
Contributor

@coot coot commented Dec 28, 2024

Description

  • Provide instances for FetchDecisionEvent for new tracing
    system.
  • Provide ToJSON instances for FetchDecision (via
    FetchDecisionToJSON newtype wrapper), TraceDecisionEvent, Point
    which can be used by both new and old tracing system.
  • Provide Verbose newtype wrapper wich ToJSON instances provide more
    verbose output.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

crocodile-dentist and others added 30 commits November 26, 2024 18:19
* ConsensusMode
* MinBigLedgerPeersForTrustedState
- Categorise `LedgerDB.SnapshotMissingChecksum` trace as `Warning`
- Expose snapshot checksum switch in config file
lehins and others added 12 commits December 20, 2024 12:06
Co-authored-by: Marcin Szamotulski <[email protected]>
* Provide instances for `FetchDecisionEvent` for new tracing
  system.
* Provide `ToJSON` instances for `FetchDecision` (via
  `FetchDecisionToJSON` newtype wrapper), `TraceDecisionEvent`, `Point`
  which can be used by both new and old tracing system.
* Provide `Verbose` newtype wrapper wich `ToJSON` instances provide more
  verbose output.
@coot coot requested a review from a team as a code owner December 28, 2024 10:27
@neilmayhew neilmayhew requested a review from a team January 9, 2025 02:07
@neilmayhew neilmayhew requested review from a team as code owners January 9, 2025 02:07
@neilmayhew neilmayhew force-pushed the nm/release-srp branch 2 times, most recently from 73b722d to eda80ed Compare January 15, 2025 01:23
@carbolymer carbolymer force-pushed the nm/release-srp branch 3 times, most recently from a9cf93a to d59cf4b Compare January 16, 2025 13:47
@neilmayhew neilmayhew force-pushed the nm/release-srp branch 3 times, most recently from 0124e36 to 91cf3f1 Compare January 17, 2025 22:57
Base automatically changed from nm/release-srp to master January 18, 2025 00:32
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Mar 4, 2025
@coot
Copy link
Contributor Author

coot commented Mar 4, 2025

The changes were merged into master in #6050.

@coot coot closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants