-
Notifications
You must be signed in to change notification settings - Fork 749
New tracing: new features and some maintenance #6377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4f9ee7 to
c4f7e74
Compare
…nOrMachine` from class LogFormatting
c4f7e74 to
dfa664a
Compare
jutaro
requested changes
Nov 27, 2025
Contributor
jutaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of changes, and I just have one question wit it. Otherwise it looks good
jutaro
approved these changes
Nov 27, 2025
Contributor
jutaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds several quality-of-life features to the new tracing system, as well as improve robustness or code quality in several places. Broken down by component, the changes contained are:
cardano-tracer:
/targets"prometheusLabels": { "<labelname>": "<labelvalue>", ... }for custom labels to be attached with Prometheus SDTracerTrace.forMachinedirectly instead of going via derivedTracerTrace.toJSON; remove unusedTracerTraceJSON instancesTracerTraceshowProblemIfAnyand for forwarding connection interruptionsrunInLoopin favour oftrace-dispatcher's implementationSystemdandNoSystemd(maintenance)trace-forward:
InitForwardingConfigconfig record type forinitForwardingandinitForwardingDelayedtrace-dispatcher:
class LogFormatting: remove redundantforHumanFromMachineandforHumanOrMachine(the system already does that inherently)Cardano.Logging.Types.TraceMessage.TraceMessagewith explicit codecs for JSON and CBORPreFormattedtype and formatters to useTraceMessage; slightly optimizehumanFormatter'FormattedMessage.FormattedCBORconstructor and acborFormatter'functiondisconnectedQueueSizeandconnectedQueueSizewithqueueSizeinTraceOptionForwarderwhile keeping config parsing backwards compatiblerunInLoopwhen the action runs sufficiently longstandardTracer's stdout thread when there are no more producers (re-enabling thecabal bench)Additionally, the PR:
forHumanFromMachineandforHumanOrMachinefrom thecardano-nodecodebase, replacing it withforHumanonly where appropriatecardano-nodeandtx-generatorChecklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12