Skip to content

Conversation

@coot
Copy link
Contributor

@coot coot commented Dec 3, 2025

Description

Improved Logging

Improved ledger peer snapshot warning. Now when use ledger peers slot is newer than the slot in the peer snapshot file the following warning is shown:

[waldorf:Startup.LedgerPeerSnapshot.Incompatible](Warning,11) Topology file misconfiguration: ignoring ledger peer snapshot recorded for SlotNo 0 since topology file specifies to use ledger peers after SlotNo 150828233.
Possible fix: update ledger peer snapshot "/opt/cardano/node/snapshot.json"

Genesis Mode

In genesis mode, the node will fail to start if the snapshot file is older than the useLedgerAfter entry in a topology file.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@coot coot requested a review from a team as a code owner December 3, 2025 09:33
@coot coot force-pushed the coot/ledger-peers-snapshot-warning branch from ba26b39 to 334d35d Compare December 3, 2025 10:13
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Dec 3, 2025
@coot coot self-assigned this Dec 3, 2025
@coot coot added networking Issues and PRs related to networking comp: networking labels Dec 3, 2025
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot enabled auto-merge December 3, 2025 10:26
coot added 2 commits December 3, 2025 13:16
This is in-line with the legacy tracing system, exchange messages are
a low level network mechanism that shouldn't clutter logs by default.
LocalStateQuery mini-protocol is running using
`typed-protoocls:stateful` API, and only it's instances are necessary.
@coot coot added this pull request to the merge queue Dec 3, 2025
Merged via the queue into master with commit 474f0b6 Dec 3, 2025
23 checks passed
@coot coot deleted the coot/ledger-peers-snapshot-warning branch December 3, 2025 13:10
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Dec 3, 2025
@coot coot changed the title Improved ledger peers snapshot warning improvemnts for new tracing system Dec 4, 2025
@coot coot changed the title improvemnts for new tracing system networking improvemnts to new tracing system Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: networking networking Issues and PRs related to networking

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants