Removed PeerT tracer #6387
Merged
Removed PeerT tracer #6387
+8
−451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmeier
requested changes
Dec 3, 2025
Contributor
mgmeier
left a comment
mgmeier
left a comment
There was a problem hiding this comment.
We haven't even had a discussion about this tracer, or about who might be using it.
Even though I see redundant information, there is unique info in the trace messages, and the metric based on it.
Furthermore, it can be easily shut off entirely in the Node config if not desired.
I'm going to RFC this PR until we had a proper conversation about it.
The information on block-fetch is exposed in other traces in the `TraceFetchClientState` tracer: * `SendFetchRequest` - when a block is requested * `CompletedBlockFetch` - when a block is fetched, includes updated `PeerFetchInFlight` information, e.g. number of blocks in flight, bytes in flight, etc from that peer. See also other messages in that tracer.
mgmeier
force-pushed
the
coot/removed-PeerT-tracer
branch
from
cc5422f to
103c3ff
Compare
mgmeier
approved these changes
Dec 4, 2025
Contributor
There was a problem hiding this comment.
LGTM.
The metric peersFromNodeKernel will disappear as a consequence of this PR; however, I believe that information can be recovered by considering the peerSelection_* bundle of metrics.
The complexity the PeerT tracer adds outweighs the little convenience it offers. I'm fine with removing it.
…; trace-dispatcher-2.11.1
mgmeier
force-pushed
the
coot/removed-PeerT-tracer
branch
from
103c3ff to
d559136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information on block-fetch is exposed in other traces in
the
TraceFetchClientStatetracer:SendFetchRequest- when a block is requestedCompletedBlockFetch- when a block is fetched, includes updatedPeerFetchInFlightinformation, e.g. number of blocks in flight,bytes in flight, etc from that peer.
See also other messages in that tracer.