Skip to content

Conversation

@mgmeier
Copy link
Contributor

@mgmeier mgmeier commented Jan 13, 2026

Description

This PR provides several small improvements derived from experience with trace-dispatcher both from an implementor's and an operator's perspective - thanks to @jasagredo for all the feedback.

The changes contained are:

  • Add strict contramap' (infix alias >!$!<) to the API, capturing a common pattern to avoid unintentional space leaks when composing tracers
  • Increased strictness when storing traced DataPoints
  • Drastically reduced fallback value for forwarding queue capacity to minimize impact of forwarding service interruption on heap size and retention
  • Removed the Forwarder backend from cardano-node's fallback configuration

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@mgmeier mgmeier force-pushed the mkarg/tracing-improvements branch from 8344c5a to 737caf7 Compare January 13, 2026 12:53
@mgmeier mgmeier marked this pull request as ready for review January 13, 2026 13:01
@mgmeier mgmeier requested review from a team as code owners January 13, 2026 13:01
@mgmeier mgmeier requested a review from jasagredo January 13, 2026 13:01
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me

@mgmeier mgmeier force-pushed the mkarg/tracing-improvements branch from fba7831 to e521921 Compare January 13, 2026 13:55
@mgmeier mgmeier added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit 9cf1e65 Jan 13, 2026
25 checks passed
@mgmeier mgmeier deleted the mkarg/tracing-improvements branch January 13, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants