refactor(config): modularize node config editing logic #103
+78
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Refactors node config editing in the cluster start scripts by extracting the genesis-hash editing and UTXO backend selection/editing logic into dedicated helper functions in common.sh, reducing duplication across start modes.
Changes:
- Added
edit_genesis_confandedit_utxo_backend_confto encapsulate config mutation logic viajq. - Updated
common-start-slowandcommon-start-fastto call the new helpers for each node config. - Adjusted file handling so edits are applied to a dedicated target path (
conf_target) in the state directory.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cardonnay_scripts/scripts/common/common.sh | Introduces the two new helper functions that apply genesis hash and UTXO backend config edits. |
| src/cardonnay_scripts/scripts/common/common-start-slow | Replaces inline jq config editing with calls to the new helper functions (copy + edit). |
| src/cardonnay_scripts/scripts/common/common-start-fast | Replaces inline genesis/UTXO backend edits with calls to the new helper functions (jq + edit). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Split node config editing in start scripts into two dedicated functions: `edit_genesis_conf` and `edit_utxo_backend_conf`, now defined in `common.sh`. This improves maintainability and clarity by separating genesis and UTXO backend configuration logic. The start scripts now call these functions for each node config, reducing duplication and making future changes easier.
mkoura
force-pushed
the
dry_edit_config
branch
from
0cc7851 to
9eca379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split node config editing in start scripts into two dedicated functions:
edit_genesis_confandedit_utxo_backend_conf, now defined incommon.sh. This improves maintainability and clarity by separating genesis and UTXO backend configuration logic. The start scripts now call these functions for each node config, reducing duplication and making future changes easier.