feat(cli): stream stdout and stderr separately in helpers #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors command execution to stream stdout and stderr separately, improving error handling and output clarity. The changes introduce concurrent streaming using threads in Python and update the shell script to capture stderr while maintaining real-time output display.
Key Changes
- Introduced threading-based concurrent streaming of stdout and stderr in Python's
run_commandhelper - Updated shell script to capture stderr separately while maintaining real-time output of both streams
- Removed the merging of stderr into stdout for better stream separation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/cardonnay/helpers.py |
Added _stream helper function and refactored run_command to use separate threads for streaming stdout and stderr concurrently instead of merging them |
src/cardonnay_scripts/scripts/common/common.sh |
Modified cardano_cli_log to capture stderr separately using process substitution while maintaining real-time display of both output streams |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactored `run_command` to stream stdout and stderr concurrently using threads, allowing for proper separation of output streams. Updated shell script logging to capture stderr while still displaying both outputs in real time. Improves error handling and log clarity for CLI operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
run_commandto stream stdout and stderr concurrently using threads, allowing for proper separation of output streams. Updated shell script logging to capture stderr while still displaying both outputs in real time. Improves error handling and log clarity for CLI operations.