Skip to content

fix(scripts): declare arrays with -a and require args #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Jan 14, 2026
Merged

fix(scripts): declare arrays with -a and require args #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/cardonnay_scripts/scripts/common/common-start-fast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,14 +410,14 @@ register_entities_in_conway() {

echo "Re-registering pools, creating CC members and DReps"

local genesis_signing=()
local -a genesis_signing=()
local skey
for skey in "$STATE_CLUSTER"/shelley/genesis-keys/genesis?.skey; do
[ -e "$skey" ] || { echo "No genesis signing keys found in ${STATE_CLUSTER}/shelley/genesis-keys, line $LINENO in ${BASH_SOURCE[0]}" >&2; exit 1; }
genesis_signing+=("--signing-key-file" "$skey")
done

local delegate_signing=()
local -a delegate_signing=()
for skey in "$STATE_CLUSTER"/shelley/delegate-keys/delegate?.skey; do
[ -e "$skey" ] || { echo "No delegate signing keys found in ${STATE_CLUSTER}/shelley/delegate-keys, line $LINENO in ${BASH_SOURCE[0]}" >&2; exit 1; }
delegate_signing+=("--signing-key-file" "$skey")
Expand All @@ -436,8 +436,8 @@ register_entities_in_conway() {

get_txins "$txin_addr" "$stop_txin_amount"

local pool_args=()
local pool_signing=()
local -a pool_args=()
local -a pool_signing=()
local i
for i in $(seq 1 "$NUM_POOLS"); do
pool_args+=( \
Expand All @@ -454,21 +454,21 @@ register_entities_in_conway() {
)
done

local cc_args=()
local -a cc_args=()
local f
for f in "$STATE_CLUSTER"/governance_data/cc_member*_committee_hot_auth.cert; do
[ -e "$f" ] || continue
cc_args+=( "--certificate-file" "$f" )
done

local cc_signing=()
local -a cc_signing=()
for f in "$STATE_CLUSTER"/governance_data/cc_member*_committee_cold.skey; do
[ -e "$f" ] || continue
cc_signing+=( "--signing-key-file" "$f" )
done

local dreps_args=()
local dreps_signing=()
local -a dreps_args=()
local -a dreps_signing=()
for i in $(seq 1 "$NUM_DREPS"); do
dreps_args+=( \
"--tx-out" "$(<"${STATE_CLUSTER}/governance_data/vote_stake_addr${i}.addr")+${DREP_DELEGATED}" \
Expand Down
4 changes: 2 additions & 2 deletions src/cardonnay_scripts/scripts/common/common-start-slow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,8 +749,8 @@ submit_gov_action() {

create_and_submit_hf_action() {
local hf_action="${1:?}"
local era="$2"
local major_version="$3"
local era="${2:?}"
local major_version="${3:?}"
local prev_txid="${4:-}"
local prev_index="${5:-0}"

Expand Down