[Dijkstra] Make ScriptPurpose.Guard and IndexOfGuard carry a Credential
#1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements changes to make ScriptPurpose.Guard and IndexOfGuard carry a Credential instead of (TxId × ScriptHash), as part of the Dijkstra era specification work on CIP-0112 and CIP-0118.
Key Changes
- Changed
ScriptPurpose.Guardto carry aCredential(which can be either a key hash or script hash) instead of(TxId × ScriptHash) - Updated
TxBodyfields to usetxGuards : ℙ Credentialinstead oftxRequiredGuards : ℙ KeyHash, and changedtxRequiredTopLevelGuardsfrom a map to a list of(Credential × Maybe Datum)pairs - Added helper functions for phase-1 validation including
groupRequiredTopLevelGuards,requiredTopLevelGuardsSatisfied, and related types
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Ledger/Dijkstra/Specification/Transaction.lagda.md | Core changes to transaction body fields (txGuards, reqSignerHashes, txRequiredTopLevelGuards) and addition of phase-1 validation functions and extensive documentation updates |
| src/Ledger/Dijkstra/Specification/Script/Validation.lagda.md | Updated ScriptPurpose.Guard type, modified rdptr to use setToList on txGuards, and updated TxInfo to include separate vkKey and txGuards fields |
| src/Ledger/Dijkstra/Specification/Abstract.lagda.md | Changed indexOfGuard signature from (TxId × ScriptHash) → ℙ (TxId × ScriptHash) to Credential → List Credential |
| src/Ledger/Dijkstra/Specification/Utxo.lagda.md | New skeleton file defining UTXO and UTXOS transitions with phase-1 checks |
| src/Ledger/Dijkstra/Specification/Utxow.lagda.md | New skeleton file defining UTXOW as wrapper around UTXO |
| src/Ledger/Dijkstra/Specification.lagda.md | Added imports for new Utxo and Utxow modules |
| src/Ledger/Conway/Specification/Utxow.lagda.md | Fixed source_path metadata from .lagda to .lagda.md |
| src/Ledger/Conway/Specification/Utxo.lagda.md | Added missing source metadata header |
| CHANGELOG.md | Documented semantic changes to txRequiredTopLevelGuards, txGuards, and reqSignerHashes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
williamdemeo
changed the base branch from
master
to
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
29516cc to
2ba8844
Compare
williamdemeo
force-pushed
the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
2 times, most recently
from
286942e to
e65a1ea
Compare
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
deeb8ad to
df6879c
Compare
williamdemeo
force-pushed
the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
from
e65a1ea to
e727cdf
Compare
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
df6879c to
43ce03e
Compare
williamdemeo
force-pushed
the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
from
e727cdf to
8e4a2c9
Compare
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
43ce03e to
ec362bc
Compare
williamdemeo
force-pushed
the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
from
8e4a2c9 to
446d9c8
Compare
+ Remove contradiction between "ref inputs may refer to earlier tx outputs in the batch" vs "all inputs must exist before applying any tx in the batch." The new text punts the exact constraint to the UTxO rules (where it belongs). + Fix Plutus bullet (old "nor earlier versions" reads like "no Plutus at all"). + Align fees with current Agda (`txFee : InTopLevel …`), but leave room for later CIP-driven updates.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
agreeing with Carlos' observation/suggestion
Agreeing with Carlos' suggestion to avoid "request."
+ a minimal `UTXOS` rule as a stub/hook (so `UTXO` can call something), + a minimal `UTXO` rule with just the new phase-1 premise (plus an explicit "calls UTXOS"), + a minimal `UTXOW`; just a wrapper over `UTXO` for now.
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
ec362bc to
5a88696
Compare
Key idea: + Keep `txGuards` as a set **for now**. + Define an ordered view `guardsList : List Credential` via `setToList`. + Make `indexOfGuard` operate on that list. + Let `rdptr` compute the `Ix` using `indexOfGuard`. For the "required top-level guards requested by subTxs" (i.e., `txRequiredTopLevelGuards` requests), we don't need a new ScriptPurpose constructor yet, because: + phase-1 ensures those requested credentials are contained in top-level `txGuards` + the later work (#1004 / #1006) will decide how to construct TxInfo / datum arguments for running those guard scripts batch-wide
williamdemeo
force-pushed
the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
from
446d9c8 to
c43c71a
Compare
williamdemeo
force-pushed
the
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
branch
from
5a88696 to
2dbea3f
Compare
Base automatically changed from
1002-dijkstra-phase-1-requiredtoplevelguards-stacked
to
master
January 8, 2026 15:39
williamdemeo
deleted the
1003-dijkstra-change-types-scriptpurposeguard-indexofguard
branch
github-project-automation
bot
moved this from In Progress
to Done
in Dijkstra formal spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stacked PR. (This PR should be rebased on and target
masteronce PR #1010 is merged.)This PR closes #1003 by changing the type/signature of
ScriptPurpose.GuardandIndexOfGuard, andguardsList : List CredentialviasetToList,indexOfGuardoperate on that list,rdptrcompute theIxusingindexOfGuard.For the "required top-level guards requested by subTxs" (
txRequiredTopLevelGuardsrequests), we don't need a newScriptPurposeconstructor yet, becausetxGuardsTxInforules for guards #1004 / [Dijkstra] batch-awarecollectP2ScriptsWithContext+ singleevalP2Scriptsat end #1006) will decide how to constructTxInfo/ datum arguments for running those guard scripts batch-wide.Copilot-generated Description
This pull request updates the representation and handling of "Guard" script purposes in the Dijkstra ledger specification. The main change is a shift from using a tuple of
TxId × ScriptHashto using aCredentialfor identifying guards, which simplifies and clarifies the indexing and referencing of guards throughout the codebase.Guard ScriptPurpose and Indexing Refactor:
Guardconstructor inScriptPurposefrom(TxId × ScriptHash)toCredential, and updated the documentation to clarify thatGuard calways indexes into the current transaction'stxGuardslist-view.indexOfGuardfunction in theindexOfrecord to take aCredentialand aList Credentialinstead of a tuple and a set, aligning it with the newGuardrepresentation.rdptrfunction to use the updatedindexOfGuardsignature and to index into thetxGuardslist forGuardpurposes, ensuring consistency with the new approach.Checklist
CHANGELOG.md