Add reqSignerHashes to neededVKeyHashes
#1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlostome
changed the title
reqSignerHashes to neededVKeyHashes
carlostome
force-pushed
the
carlos/validate-reqSignerHashes
branch
3 times, most recently
from
0dc1058 to
3eea3e3
Compare
carlostome
force-pushed
the
carlos/validate-reqSignerHashes
branch
from
3eea3e3 to
9ba4379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
neededVKeyHashesinUTXOW, in which the set ofreqSignerHasheswas not being checked against the witnesses provided in a transaction (see Fig. 11 in alonzo).Blocked by #1030Checklist
CHANGELOG.md