-
Notifications
You must be signed in to change notification settings - Fork 20
[Dijkstra] GOV and CERTS rules #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dijkstra] GOV and CERTS rules #1043
Conversation
As a first pass we simply copy over four Conway modules to Dijkstra: + Enact + Gov + Ratify + Script.Base And make the following actual Dijkstra modules (instead of just importing the Conway version): + Certs + Gov + Gov.Actions + PParams
|
@carlostome the CERTS and GOV rules go through virtually unchanged from Conway (as expected) and everything type-checks, so we could probably merge it in to master "as is" and then refine with follow-up PRs. On second thought, we should merge the UTXO/UTXOS PR and your UTXOW PR first, then rebase this PR branch on master. |
Not sure why `rmOrphanDRepVotes` was commented out. Does it need to be adjusted for Dijkstra?
|
@carlostome I also cleaned up the Ledger module a bit. Was there a reason |
Because of the missing GOVS. |
carlostome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This closes Issue #1037.
As a first pass, copy over four Conway modules to Dijkstra:
and make the following legit Dijkstra modules by copying over the contents of the analogous Conway and adjusting as necessary (instead of merely importing from Conway):
Checklist
CHANGELOG.md