Skip to content

Conversation

@williamdemeo
Copy link
Member

Description

This closes Issue #1037.

As a first pass, copy over four Conway modules to Dijkstra:

  • Enact
  • Gov
  • Ratify
  • Script.Base

and make the following legit Dijkstra modules by copying over the contents of the analogous Conway and adjusting as necessary (instead of merely importing from Conway):

  • Certs
  • Gov
  • Gov.Actions
  • PParams

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

As a first pass we simply copy over four Conway modules to Dijkstra:

+ Enact
+ Gov
+ Ratify
+ Script.Base

And make the following actual Dijkstra modules (instead of just
importing the Conway version):

+ Certs
+ Gov
+ Gov.Actions
+ PParams
@williamdemeo williamdemeo changed the title [Dijkstra] WIP - implement GOV rule [Dijkstra] WIP - GOV and CERTS rules Jan 23, 2026
@williamdemeo williamdemeo marked this pull request as ready for review January 23, 2026 05:30
@williamdemeo
Copy link
Member Author

williamdemeo commented Jan 23, 2026

@carlostome the CERTS and GOV rules go through virtually unchanged from Conway (as expected) and everything type-checks, so we could probably merge it in to master "as is" and then refine with follow-up PRs.

On second thought, we should merge the UTXO/UTXOS PR and your UTXOW PR first, then rebase this PR branch on master.

Not sure why `rmOrphanDRepVotes` was commented out.
Does it need to be adjusted for Dijkstra?
@williamdemeo
Copy link
Member Author

@carlostome I also cleaned up the Ledger module a bit. Was there a reason rmOrphanDRepVotes was commented out? Should it be changed for Dijkstra?

@williamdemeo williamdemeo changed the title [Dijkstra] WIP - GOV and CERTS rules [Dijkstra] GOV and CERTS rules Jan 23, 2026
@carlostome
Copy link
Collaborator

@carlostome I also cleaned up the Ledger module a bit. Was there a reason rmOrphanDRepVotes was commented out? Should it be changed for Dijkstra?

Because of the missing GOVS.

Copy link
Collaborator

@carlostome carlostome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamdemeo williamdemeo merged commit ccdf3e8 into master Jan 23, 2026
15 checks passed
@williamdemeo williamdemeo deleted the 1037-dijkstra-implement-gov-and-govs-rules branch January 23, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dijkstra] Implement GOV and GOVS rules

3 participants