Add time translation functions #1045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
commented
Jan 23, 2026
Comment on lines
57
to
72
| POSIXTime = ℕ | ||
| POSIXTimeRange = Maybe POSIXTime × Maybe POSIXTime | ||
| ValidityInterval = Maybe Slot × Maybe Slot | ||
| slotToPOSIXTime : EpochInfo → SystemStart → Slot → Maybe POSIXTime | ||
| slotToPOSIXTime ei sysS vs = do | ||
| t ← epochInfoSlotToUTCTime ei sysS vs | ||
| just (utcTimeToPOSIXSeconds t * 1000) | ||
| transVITime | ||
| : EpochInfo | ||
| → SystemStart | ||
| → ValidityInterval | ||
| → POSIXTimeRange | ||
| transVITime ei sysS (vi , vf) = | ||
| ((vi >>= slotToPOSIXTime ei sysS) , (vf >>= slotToPOSIXTime ei sysS)) |
Collaborator
Author
There was a problem hiding this comment.
Are POSIXTime and POSIXTimeRange supposed to be in the ledger spec? Should I implement them as in the Haskell implementation?
The Alonzo spec doesn't say anything about them.
facundominguez
commented
Jan 23, 2026
Comment on lines
34
to
46
| field UTCTime : Type | ||
| EpochInfo : Type | ||
| SystemStart : Type | ||
| EI : EpochInfo | ||
| SysSt : SystemStart |
Collaborator
Author
There was a problem hiding this comment.
Is making these abstract the way it should be done?
facundominguez
force-pushed
the
fd/time
branch
2 times, most recently
from
14dad53 to
4bada15
Compare
facundominguez
force-pushed
the
fd/txrdmrs
branch
from
27c23f2 to
d2a1c6e
Compare
facundominguez
force-pushed
the
fd/time
branch
from
5cf45d9 to
ca26272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #723