Skip to content

[Dijkstra] Implement legacy-mode for V1-V3 Plutus scripts#1049

Merged
carlostome merged 3 commits intomasterfrom
carlos/implement-legacy-mode
Feb 18, 2026
Merged

[Dijkstra] Implement legacy-mode for V1-V3 Plutus scripts#1049
carlostome merged 3 commits intomasterfrom
carlos/implement-legacy-mode

Conversation

@carlostome
Copy link
Collaborator

@carlostome carlostome commented Jan 27, 2026

Description

Blocked by #1076
Closes #1047.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@williamdemeo williamdemeo self-requested a review January 29, 2026 15:57
@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch from 987d393 to b5c4129 Compare January 29, 2026 16:21
@carlostome carlostome changed the base branch from master to carlos/remove-subutxos-move-state-upd-to-utxo January 29, 2026 16:23
@carlostome carlostome force-pushed the carlos/remove-subutxos-move-state-upd-to-utxo branch 7 times, most recently from 9a77cbb to f9fa699 Compare January 30, 2026 15:44
Base automatically changed from carlos/remove-subutxos-move-state-upd-to-utxo to master January 30, 2026 15:49
@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch from b5c4129 to 5608841 Compare February 2, 2026 12:10
@carlostome carlostome marked this pull request as ready for review February 2, 2026 12:21
Copy link
Member

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, and probably even most of the way there. Nice work! Let's talk more about it tomorrow.

∙ ∀[ s ∈ p1Scripts ] (hash s ∈ neededScriptHashes → validP1Script witsKeyHashes txVldt s)
∙ neededScriptHashes ⊆ mapˢ hash topLevelScripts
∙ neededVKeyHashes ⊆ witsKeyHashes
∙ neededDataHashes ⊆ txDataHashes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern about this line... but I'll have to think more about it before I can tell if it's worth raising/addressing. (Basically I'm wondering if this inclusion is too strict and we should union the rhs with refInputsDataHashes.)

Copy link
Member

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, I can't suggest replacing the whole Dec-UsesV4Features definition. I guess that's because it's not part of your PR...? Anyway, I think you can see that my intention is to replace that definition with the two new ones provided.

@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch from 5608841 to 1d51fdd Compare February 6, 2026 13:41
@carlostome carlostome changed the base branch from master to 1075-dijkstra-require-guards-in-utxowsubutxow February 6, 2026 13:41
@carlostome carlostome force-pushed the 1075-dijkstra-require-guards-in-utxowsubutxow branch 3 times, most recently from d5b59a2 to 6be84cb Compare February 9, 2026 15:45
@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch 2 times, most recently from 88b2f59 to bfbc17b Compare February 10, 2026 12:23
@carlostome carlostome force-pushed the 1075-dijkstra-require-guards-in-utxowsubutxow branch from 6c3a420 to f96dc0c Compare February 11, 2026 10:51
Base automatically changed from 1075-dijkstra-require-guards-in-utxowsubutxow to master February 11, 2026 13:33
@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch 2 times, most recently from edb74ff to 6044f3a Compare February 12, 2026 16:32
Copy link
Member

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggested change. Otherwise, looks great. Nice work!

@carlostome carlostome force-pushed the carlos/implement-legacy-mode branch from ad9abb8 to 75c5dfa Compare February 18, 2026 09:44
@carlostome carlostome enabled auto-merge (squash) February 18, 2026 09:44
@carlostome carlostome merged commit ecddc57 into master Feb 18, 2026
7 checks passed
@carlostome carlostome deleted the carlos/implement-legacy-mode branch February 18, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dijkstra] Implement legacy mode validation when V1-V3 scripts are present in the top-level tx

2 participants