[Dijkstra] Implement legacy-mode for V1-V3 Plutus scripts#1049
[Dijkstra] Implement legacy-mode for V1-V3 Plutus scripts#1049carlostome merged 3 commits intomasterfrom
Conversation
987d393 to
b5c4129
Compare
9a77cbb to
f9fa699
Compare
b5c4129 to
5608841
Compare
williamdemeo
left a comment
There was a problem hiding this comment.
This is a great start, and probably even most of the way there. Nice work! Let's talk more about it tomorrow.
| ∙ ∀[ s ∈ p1Scripts ] (hash s ∈ neededScriptHashes → validP1Script witsKeyHashes txVldt s) | ||
| ∙ neededScriptHashes ⊆ mapˢ hash topLevelScripts | ||
| ∙ neededVKeyHashes ⊆ witsKeyHashes | ||
| ∙ neededDataHashes ⊆ txDataHashes |
There was a problem hiding this comment.
I have a concern about this line... but I'll have to think more about it before I can tell if it's worth raising/addressing. (Basically I'm wondering if this inclusion is too strict and we should union the rhs with refInputsDataHashes.)
williamdemeo
left a comment
There was a problem hiding this comment.
Apparently, I can't suggest replacing the whole Dec-UsesV4Features definition. I guess that's because it's not part of your PR...? Anyway, I think you can see that my intention is to replace that definition with the two new ones provided.
5608841 to
1d51fdd
Compare
d5b59a2 to
6be84cb
Compare
88b2f59 to
bfbc17b
Compare
6c3a420 to
f96dc0c
Compare
edb74ff to
6044f3a
Compare
williamdemeo
left a comment
There was a problem hiding this comment.
One minor suggested change. Otherwise, looks great. Nice work!
ad9abb8 to
75c5dfa
Compare
Description
Blocked by #1076Closes #1047.
Checklist
CHANGELOG.md