Skip to content

Comments

Added HSPlutusScript, changed refScriptsSize#630

Merged
Soupstraw merged 1 commit intomasterfrom
jj/script-size
Jan 7, 2025
Merged

Added HSPlutusScript, changed refScriptsSize#630
Soupstraw merged 1 commit intomasterfrom
jj/script-size

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Dec 20, 2024

Description

This PR adds the HSPlutusScript, which has the hash of the script and the size of the serialization of that script.

I also had to make a change to how refScriptsSize is calculated, because the implementation does not remove duplicate scripts and adds together the sizes of all the scripts even when there are multiple with the same hash.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/script-size branch 2 times, most recently from a18d6c8 to 2bdb44e Compare January 3, 2025 14:11
@Soupstraw Soupstraw marked this pull request as ready for review January 3, 2025 14:12
@Soupstraw Soupstraw changed the title Added HSPlutusScript Added HSPlutusScript, changed refScriptSize Jan 3, 2025
@Soupstraw Soupstraw changed the title Added HSPlutusScript, changed refScriptSize Added HSPlutusScript, changed refScriptsSize Jan 3, 2025
Copy link
Member

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Soupstraw Soupstraw merged commit 424ab29 into master Jan 7, 2025
10 checks passed
@Soupstraw Soupstraw deleted the jj/script-size branch January 7, 2025 10:57
github-actions bot added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants