Skip to content

Conversation

@facundominguez
Copy link
Collaborator

Fixes #951

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the fPools field in PState to align with the Shelley specification, addressing issue #951. The change adds a new field to track pool parameters separately from the main pools mapping.

Key changes:

  • Added fPools field to the PState record type
  • Updated all PState constructor calls and pattern matches to include the new fPools field
  • Modified epoch boundary logic to reset fPools to empty map while preserving pools

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Ledger/Conway/Specification/Certs.lagda.md Added fPools field to PState record and updated POOL transition rules
src/Ledger/Conway/Specification/PoolReap.lagda.md Updated pool reaping logic to filter both pools and fPools by retired pools
src/Ledger/Conway/Specification/Epoch.lagda.md Added fPools initialization logic and threaded pState' through epoch updates
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda Updated variable names and references to use pState'' for consistency
src/Ledger/Conway/Conformance/Certs.agda Updated POOL transition constructors to include fPools field
src/Ledger/Conway/Conformance/Epoch.agda Updated pool state construction during epoch transitions to include fPools
CHANGELOG.md Documented the implementation of fPoolParams field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@carlostome carlostome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facundominguez facundominguez merged commit 58e1771 into master Oct 17, 2025
14 checks passed
@facundominguez facundominguez deleted the fd/fpoolparams branch October 17, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement fPoolParams from the Shelley spec

2 participants