Only accept CC if minsize and threshold are both zero #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
changed the title
Collaborator
|
The |
Contributor
Author
|
Turns out there was another bug as well. The |
carlostome
approved these changes
Nov 10, 2025
Collaborator
carlostome
left a comment
carlostome
left a comment
There was a problem hiding this comment.
LGTM!
To record, the conformance test from IntersectMBO/cardano-ledger#5184 now succeeds.
Soupstraw
force-pushed
the
jj/cc-vote-minsize-fix
branch
2 times, most recently
from
0142f14 to
0f69c7f
Compare
williamdemeo
approved these changes
Nov 11, 2025
Member
williamdemeo
left a comment
williamdemeo
left a comment
There was a problem hiding this comment.
Nice work Joosep! There may be some minor fixes needed (e.g., for the mkdocs site) after merging master into this branch, but nothing major. (In fact, it will likely be fixed once I merge the "nav fix" PR that I'm about to create, so you won't have to worry about it.)
carlostome
force-pushed
the
jj/cc-vote-minsize-fix
branch
2 times, most recently
from
0f69c7f to
0f0395d
Compare
carlostome
force-pushed
the
jj/cc-vote-minsize-fix
branch
from
0f0395d to
212b889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how CC votes are counted in the case where there aren't enough CC members and the threshold is zero. According to the discussion in IntersectMBO/cardano-ledger#5170, CC should accept only if both the
ccMinSizeand threshold are set to zero.Checklist
CHANGELOG.md