Motivate the conformance model #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I added the contents to |
facundominguez
force-pushed
the
fd/conformance-motivation
branch
from
d9bcadd to
367376d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts the conformance model module from a plain Agda file to a literate Agda file with extensive documentation explaining the purpose and design of the conformance model.
- Added comprehensive documentation explaining why the conformance model differs from the Conway specification
- Documented the motivation, guarantees, and alternatives considered for the conformance model design
- Preserved all existing module imports in the literate format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Ledger/Conway/Conformance.lagda.md | New literate Agda file with detailed documentation explaining the conformance model's purpose, design decisions, and relationship to the Haskell implementation |
| src/Ledger/Conway/Conformance.agda | Removed in favor of the literate Agda version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
facundominguez
commented
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #924