Refactor accepted by CC #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
carlostome
force-pushed
the
carlos/change-accepted-by-cc
branch
2 times, most recently
from
f5e7854 to
9f7ceea
Compare
13 tasks
carlostome
force-pushed
the
carlos/change-accepted-by-cc
branch
from
9f7ceea to
4c1b265
Compare
carlostome
force-pushed
the
carlos/change-accepted-by-cc
branch
from
7fa8771 to
246ae4a
Compare
WhatisRT
approved these changes
Dec 8, 2025
Collaborator
WhatisRT
left a comment
WhatisRT
left a comment
There was a problem hiding this comment.
I left some comments, but overall LGTM
| accepted = (acceptedStake /₀ totalStake) ≥ t | ||
| × (sizeActiveCC ≥ ccMinSize ⊎ (Is-nothing mT × ccMinSize ≡ 0)) | ||
| accepted = if mT then (λ {t} → sizeActiveCC ≥ ccMinSize × (acceptedStake /₀ totalStake) ≥ t) | ||
| else ⊤ |
Collaborator
There was a problem hiding this comment.
Since we're showing this in the actual documentation, I wonder if it'd be a good idea to provide an alias called True for this. And similarly for False.
Collaborator
Author
There was a problem hiding this comment.
True and False are already used in the spec as proofs of Decidable predicates. I'll open an issue about this so we don't forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
acceptedByCCrejects a NoConfidence proposal if the committee is empty but theminSizeis not 0.I'm not sure if this is the intended behaviour but I suppose no since CC has no bearing on NoConfidence motions.
This is related to #209 and (likely the cause of) IntersectMBO/cardano-ledger#5418
Pinging @Soupstraw and @WhatisRT
EDIT:
This PR refactors
acceptedByCCto simplify the logic.Checklist
CHANGELOG.md