Skip to content

fix: “Save Draft” Button Disabled When Valid Guardrails Script is Pro… #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihajlovicMilos1995 merged 1 commit into from
May 9, 2025
Merged

fix: “Save Draft” Button Disabled When Valid Guardrails Script is Pro… #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 81 additions & 56 deletions pdf-ui/src/components/CreationGoveranceAction/Step2.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
import {Box, Button, Card, CardContent, MenuItem, TextField, Typography } from '@mui/material';
import {
Box,
Button,
Card,
CardContent,
MenuItem,
TextField,
Typography,
} from '@mui/material';
import { useEffect, useState } from 'react';
import { LinkManager, WithdrawalsManager, ConstitutionManager} from '.';
import { LinkManager, WithdrawalsManager, ConstitutionManager } from '.';
import { useAppContext } from '../../context/context';
import { getGovernanceActionTypes } from '../../lib/api';
import { containsString, maxLengthCheck } from '../../lib/utils';
Expand All @@ -22,7 +30,7 @@ const Step2 = ({
withdrawalsErrors,
setWithdrawalsErrors,
constitutionErrors,
setConstitutionErrors
setConstitutionErrors,
}) => {
const titleMaxLength = 80;
const abstractMaxLength = 2500;
Expand All @@ -34,9 +42,10 @@ const Step2 = ({
)?.label || ''
);
const [selectedGovActionId, setSelectedGovActionId] = useState(
proposalData?.attributes?.content?.attributes?.gov_action_type?.id || null
proposalData?.attributes?.content?.attributes?.gov_action_type?.id ||
null
);
const [isDraftDisabled,setIsDraftDisabled] = useState(true);
const [isDraftDisabled, setIsDraftDisabled] = useState(true);
const handleChange = (e) => {
const selectedValue = e.target.value;
const selectedLabel = governanceActionTypes.find(
Expand All @@ -46,15 +55,16 @@ const Step2 = ({
setProposalData((prev) => ({
...prev,
gov_action_type_id: selectedValue,
proposal_withdrawals:[{ prop_receiving_address: null, prop_amount: null }]
proposal_withdrawals: [
{ prop_receiving_address: null, prop_amount: null },
],
}));
if(selectedValue != 3)
{ //cleanup fields co
if (selectedValue != 3) {
//cleanup fields co
setProposalData((prev) => ({
...prev,
proposal_constitution_content:{}
proposal_constitution_content: {},
}));

}
setSelectedGovActionId(selectedValue);
setSelectedGovActionName(selectedLabel);
Expand Down Expand Up @@ -104,7 +114,7 @@ const Step2 = ({
}

setHelperText((prev) => ({
...prev,
...prev,
[errorField]: errorMessage === true ? '' : errorMessage,
}));

Expand All @@ -118,30 +128,39 @@ const Step2 = ({
fetchGovernanceActionTypes();
}, []);

useEffect(()=>{
setSelectedGovActionName(governanceActionTypes.find(
(option) => option?.value === +proposalData?.gov_action_type_id
)?.label || '')
setSelectedGovActionId(+proposalData?.gov_action_type_id)
useEffect(() => {
setSelectedGovActionName(
governanceActionTypes.find(
(option) => option?.value === +proposalData?.gov_action_type_id
)?.label || ''
);
setSelectedGovActionId(+proposalData?.gov_action_type_id);
}, [governanceActionTypes]);

},[governanceActionTypes])
useEffect(() => {
if(proposalData?.gov_action_type_id && proposalData?.prop_name?.length !== 0)
{
setIsDraftDisabled(false)
}
else
{
setIsDraftDisabled(true)
if (
proposalData?.gov_action_type_id &&
proposalData?.prop_name?.length !== 0
) {
setIsDraftDisabled(false);
} else {
setIsDraftDisabled(true);
}
if(proposalData?.proposal_constitution_content?.prop_have_guardrails_script)
{
if(!proposalData.proposal_constitution_content.prop_guardrails_script_url && !proposalData.proposal_constitution_content.prop_guardrails_script_hash)
setIsDraftDisabled(false)
else
setIsDraftDisabled(true)
if (
proposalData?.proposal_constitution_content
?.prop_have_guardrails_script
) {
if (
proposalData.proposal_constitution_content
.prop_guardrails_script_url &&
proposalData.proposal_constitution_content
.prop_guardrails_script_hash
) {
setIsDraftDisabled(false);
} else setIsDraftDisabled(true);
}
},[proposalData])
}, [proposalData]);

return (
<Card>
<CardContent
Expand Down Expand Up @@ -387,34 +406,40 @@ const Step2 = ({
: 'rationale-helper',
}}
/>
{ /// Treasury
{
/// Treasury
selectedGovActionId == 2 ? (
<>
<Box
sx={{
align: 'center',
textAlign: 'center',
mt: 2,
}}
>
<WithdrawalsManager
<>
<Box
sx={{
align: 'center',
textAlign: 'center',
mt: 2,
}}
>
<WithdrawalsManager
proposalData={proposalData}
setProposalData={setProposalData}
withdrawalsErrors={withdrawalsErrors}
setWithdrawalsErrors={
setWithdrawalsErrors
}
/>
</Box>
</>
) : null
}
{
/// 'Constitution'
selectedGovActionId === 3 ? (
<ConstitutionManager
proposalData={proposalData}
setProposalData={setProposalData}
withdrawalsErrors={withdrawalsErrors}
setWithdrawalsErrors={setWithdrawalsErrors}
/>
</Box>
</>

) : null}
{ /// 'Constitution'
selectedGovActionId === 3 ? (
<ConstitutionManager
proposalData={proposalData}
setProposalData={setProposalData}
constitutionManagerErrors={constitutionErrors}
setConstitutionManagerErrors={setConstitutionErrors}
></ConstitutionManager>
constitutionManagerErrors={constitutionErrors}
setConstitutionManagerErrors={
setConstitutionErrors
}
></ConstitutionManager>
) : null
}
<Box
Expand Down