GovTool - v2.0.17 candidate

CHANGELOG.md

@@ -14,13 +14,14 @@ changes.
 
 ### Fixed
 
+- allow casting same vote with a different rationale [Issue 3191](https://github.com/IntersectMBO/govtool/issues/3191)
+
 ### Changed
 
 ### Removed
 
 ## [v2.0.16](https://github.com/IntersectMBO/govtool/releases/tag/v2.0.16) 2025-03-17
 
-
 ### Added
 
 - Add support for preprod in matomo analytics [Issue 3173](https://github.com/IntersectMBO/govtool/issues/3173)

govtool/frontend/Dockerfile

@@ -47,8 +47,11 @@ RUN npm install
 COPY . .
 RUN npm run build
 
-FROM nginx:stable-alpine
+FROM fholzer/nginx-brotli:v1.23.4
+
 EXPOSE 80
+
 COPY nginx.conf /etc/nginx/conf.d/default.conf
+
 COPY --from=builder /src/maintenance-page/index.html /usr/share/nginx/html/maintenance.html
 COPY --from=builder /src/dist /usr/share/nginx/html

govtool/frontend/Dockerfile.qovery

@@ -30,8 +30,11 @@ RUN npm install
 COPY . .
 RUN npm run build
 
-FROM nginx:stable-alpine
+FROM fholzer/nginx-brotli:v1.23.4
+
 EXPOSE 80
+
 COPY nginx.conf /etc/nginx/conf.d/default.conf
+
 COPY --from=builder /src/maintenance-page/index.html /usr/share/nginx/html/maintenance.html
 COPY --from=builder /src/dist /usr/share/nginx/html

govtool/frontend/src/consts/images.ts

@@ -1,17 +1,17 @@
 export const IMAGES = {
   appLogo: "/images/CardanoLogo.svg",
-  appLogoWithoutText: "/images/AppLogoWithoutText.png",
-  bgBlue: "/images/BGBlue.png",
-  bgOrange: "/images/BGOrange.png",
-  errorPageImage: "/images/ErrorPageImage.png",
-  govActionDefaultImage: "/images/GovActionDefault.png",
-  govActionDelegateImage: "/images/GovActionDelegate.png",
-  govActionListImage: "/images/GovActionList.png",
-  govActionRegisterImage: "/images/GovActionRegister.png",
-  heroImage: "/images/HeroImage.png",
-  proposeGovActionImage: "/images/ProposeGovAction.png",
-  directVoterImage: "/images/GovActionsDirectVoter.png",
-  successImage: "/images/Success.png",
-  warningImage: "/images/Warning.png",
-  warningYellowImage: "/images/WarningYellow.png",
+  appLogoWithoutText: "/images/AppLogoWithoutText.webp",
+  bgBlue: "/images/BGBlue.webp",
+  bgOrange: "/images/BGOrange.webp",
+  errorPageImage: "/images/ErrorPageImage.webp",
+  govActionDefaultImage: "/images/GovActionDefault.webp",
+  govActionDelegateImage: "/images/GovActionDelegate.webp",
+  govActionListImage: "/images/GovActionList.webp",
+  govActionRegisterImage: "/images/GovActionRegister.webp",
+  heroImage: "/images/HeroImage.webp",
+  proposeGovActionImage: "/images/ProposeGovAction.webp",
+  directVoterImage: "/images/GovActionsDirectVoter.webp",
+  successImage: "/images/Success.webp",
+  warningImage: "/images/Warning.webp",
+  warningYellowImage: "/images/WarningYellow.webp",
 };

govtool/frontend/src/hooks/forms/useVoteActionForm.tsx

@@ -69,8 +69,7 @@ export const useVoteActionForm = ({
     txHash !== null &&
     index !== undefined &&
     index !== null &&
-    !areFormErrors &&
-    previousVote?.vote !== vote;
+    !areFormErrors;
 
   const confirmVote = useCallback(
     async (values: VoteActionFormValues) => {

govtool/frontend/vite.config.ts

@@ -16,6 +16,17 @@ const viteConfig = defineViteConfig({
   define: {
     "process.env": {},
   },
+  build: {
+    chunkSizeWarningLimit: 512,
+    minify: "terser",
+    terserOptions: {
+      compress: {
+        keep_infinity: true,
+        drop_console: true,
+        drop_debugger: true,
+      },
+    },
+  },
   resolve: {
     alias: [
       { find: "@", replacement: path.resolve(__dirname, "./src") },

tests/govtool-frontend/playwright/lib/pages/governanceActionDetailsPage.ts

@@ -1,6 +1,6 @@
 import environments from "@constants/environments";
 import { downloadMetadata } from "@helpers/metadata";
-import { Download, Page, Response } from "@playwright/test";
+import { Download, expect, Page, Response } from "@playwright/test";
 import metadataBucketService from "@services/metadataBucketService";
 import { IProposal } from "@types";
 import { withTxConfirmation } from "lib/transaction.decorator";
@@ -76,8 +76,10 @@ export default class GovernanceActionDetailsPage {
   }
 
   @withTxConfirmation
-  async vote(context?: string) {
-    await this.yesVoteRadio.click();
+  async vote(context?: string, isAlreadyVoted: boolean = false) {
+    if (!isAlreadyVoted) {
+      await this.yesVoteRadio.click();
+    }
 
     if (context) {
       await this.contextBtn.click();
@@ -98,6 +100,12 @@ export default class GovernanceActionDetailsPage {
       await this.page.getByTestId("go-to-vote-modal-button").click();
     }
 
+    const isVoteButtonEnabled = await this.voteBtn.isEnabled();
+
+    await expect(this.voteBtn, {
+      message: !isVoteButtonEnabled && "Vote button is not enabled",
+    }).toBeEnabled({ timeout: 60_000 });
+
     await this.voteBtn.click();
   }
 
@@ -126,10 +134,12 @@ export default class GovernanceActionDetailsPage {
 
   async getDRepTotalAbstainVoted(
     proposal: IProposal,
-    metricsResponsePromise: Promise<Response>
+    totalStakeResponsePromise: Promise<Response>
   ): Promise<number | undefined> {
-    const metricsResponses = await Promise.resolve(metricsResponsePromise);
-    const alwaysAbstainVotingPower = await metricsResponses
+    const totalStakeResponses = await Promise.resolve(
+      totalStakeResponsePromise
+    );
+    const alwaysAbstainVotingPower = await totalStakeResponses
       .json()
       .then((data) => data.alwaysAbstainVotingPower);
 
@@ -154,6 +164,6 @@ export default class GovernanceActionDetailsPage {
   @withTxConfirmation
   async reVote() {
     await this.noVoteRadio.click();
-    await this.voteBtn.click();
+    await this.changeVoteBtn.click();
   }
 }

tests/govtool-frontend/playwright/lib/pages/governanceActionsPage.ts

@@ -23,6 +23,10 @@ export default class GovernanceActionsPage {
     await this.page.waitForTimeout(2_000); // Waits to ensure the alert-success popup does not interfere
   }
 
+  get currentPage(): Page {
+    return this.page;
+  }
+
   async viewProposal(
     proposal: IProposal
   ): Promise<GovernanceActionDetailsPage> {

tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts

@@ -46,13 +46,11 @@ export default class OutcomeDetailsPage {
   ): Promise<number | undefined> {
     const alwaysAbstainVotingPower = await metricsResponses
       .json()
-      .then((res) => res.alwaysAbstainVotingPower);
-    if (
-      alwaysAbstainVotingPower &&
-      typeof alwaysAbstainVotingPower === "number"
-    ) {
+      .then((res) => res.always_abstain_voting_power);
+
+    if (alwaysAbstainVotingPower) {
       const totalAbstainVoted =
-        alwaysAbstainVotingPower + parseInt(proposal.abstain_votes);
+        parseInt(alwaysAbstainVotingPower) + parseInt(proposal.abstain_votes);
 
       return totalAbstainVoted;
     } else {

tests/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.dRep.spec.ts

@@ -116,8 +116,6 @@ test.describe("Temporary DReps", async () => {
   });
 
   test("4J. Should include metadata anchor in the vote transaction", async ({}, testInfo) => {
-    test.skip(); // Skipped: Vote context is not displayed in UI to validate
-
     test.setTimeout(testInfo.timeout + environments.txTimeOut);
 
     const govActionsPage = new GovernanceActionsPage(dRepPage);
@@ -130,6 +128,8 @@ test.describe("Temporary DReps", async () => {
 
     await govActionsPage.votedTab.click();
     await govActionsPage.viewFirstVotedProposal();
+
+    //  Vote context is not displayed in UI to validate
     expect(false, "No vote context displayed").toBe(true);
   });
 });
@@ -150,10 +150,6 @@ test.describe("Check vote count", () => {
       )
     );
 
-    const metricsResponsePromise = page.waitForResponse((response) =>
-      response.url().includes(`network/metrics`)
-    );
-
     const governanceActionsPage = new GovernanceActionsPage(page);
     await governanceActionsPage.goto();
 
@@ -179,19 +175,23 @@ test.describe("Check vote count", () => {
           storageState: ".auth/dRep01.json",
           wallet: dRep01Wallet,
         });
+
+        const totalStakeResponsePromise = dRepPage.waitForResponse((response) =>
+          response.url().includes(`network/total-stake`)
+        );
         const govActionDetailsPage = new GovernanceActionDetailsPage(dRepPage);
         await govActionDetailsPage.goto(
           `${proposalToCheck.txHash}#${proposalToCheck.index}`
         );
 
+        await govActionDetailsPage.showVotesBtn.click();
+
         const dRepTotalAbstainVote =
           await govActionDetailsPage.getDRepTotalAbstainVoted(
             proposalToCheck,
-            metricsResponsePromise
+            totalStakeResponsePromise
           );
 
-        await govActionDetailsPage.showVotesBtn.click();
-
         // check dRep votes
         if (await areDRepVoteTotalsDisplayed(proposalToCheck)) {
           await expect(govActionDetailsPage.dRepYesVotes).toHaveText(

tests/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.spec.ts

@@ -222,10 +222,6 @@ test("4K. Should display correct vote counts on governance details page for disc
     )
   );
 
-  const metricsResponsePromise = page.waitForResponse((response) =>
-    response.url().includes(`network/metrics`)
-  );
-
   const governanceActionsPage = new GovernanceActionsPage(page);
   await governanceActionsPage.goto();
   const responses = await Promise.all(responsesPromise);
@@ -248,6 +244,9 @@ test("4K. Should display correct vote counts on governance details page for disc
     uniqueProposalTypes.map(async (proposalToCheck) => {
       const newPage = await browser.newPage();
       injectLogger(newPage);
+      const totalStakeResponsePromise = newPage.waitForResponse((response) =>
+        response.url().includes(`network/total-stake`)
+      );
       const govActionDetailsPage = new GovernanceActionDetailsPage(newPage);
       await govActionDetailsPage.goto(
         `${proposalToCheck.txHash}#${proposalToCheck.index}`
@@ -256,7 +255,7 @@ test("4K. Should display correct vote counts on governance details page for disc
       const dRepTotalAbstainVote =
         await govActionDetailsPage.getDRepTotalAbstainVoted(
           proposalToCheck,
-          metricsResponsePromise
+          totalStakeResponsePromise
         );
 
       // check dRep votes

tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts

@@ -136,7 +136,6 @@ test.describe("Proposal checks", () => {
 
 test.describe("Perform voting", () => {
   let govActionDetailsPage: GovernanceActionDetailsPage;
-  let dRepPage: Page;
 
   test.beforeEach(async ({ page, browser }) => {
     test.slow(); // Due to queue in pop wallets
@@ -145,7 +144,7 @@ test.describe("Perform voting", () => {
 
     const tempDRepAuth = await createTempDRepAuth(page, wallet);
 
-    dRepPage = await createNewPageWithWallet(browser, {
+    const dRepPage = await createNewPageWithWallet(browser, {
       storageState: tempDRepAuth,
       wallet,
       enableStakeSigning: true,
@@ -166,7 +165,7 @@ test.describe("Perform voting", () => {
       : await govActionsPage.viewFirstProposal();
   });
 
-  test("5E. Should re-vote with new data on a already voted governance action", async ({}, testInfo) => {
+  test("5E. Should re-vote with change vote on an already voted governance action", async ({}, testInfo) => {
     test.setTimeout(testInfo.timeout + 2 * environments.txTimeOut);
 
     await govActionDetailsPage.vote();
@@ -175,7 +174,7 @@ test.describe("Perform voting", () => {
       govActionDetailsPage.currentPage
     );
 
-    await dRepPage.waitForTimeout(5_000);
+    await governanceActionsPage.currentPage.reload();
 
     await governanceActionsPage.votedTab.click();
 
@@ -190,7 +189,7 @@ test.describe("Perform voting", () => {
     govActionDetailsPage = await governanceActionsPage.viewFirstVotedProposal();
     await govActionDetailsPage.reVote();
 
-    await dRepPage.reload();
+    await govActionDetailsPage.currentPage.reload();
 
     await governanceActionsPage.votedTab.click();
 
@@ -224,6 +223,56 @@ test.describe("Perform voting", () => {
     });
   });
 
+  test("5L. Should update context on an already voted governance action without changing the vote", async ({}, testInfo) => {
+    test.setTimeout(testInfo.timeout + 2 * environments.txTimeOut);
+
+    await govActionDetailsPage.vote();
+
+    const governanceActionsPage = new GovernanceActionsPage(
+      govActionDetailsPage.currentPage
+    );
+
+    await governanceActionsPage.currentPage.reload();
+
+    await governanceActionsPage.votedTab.click();
+
+    await govActionDetailsPage.currentPage.evaluate(() =>
+      window.scrollTo(0, 500)
+    );
+
+    await expect(
+      govActionDetailsPage.currentPage.getByTestId("my-vote").getByText("Yes")
+    ).toBeVisible();
+
+    govActionDetailsPage = await governanceActionsPage.viewFirstVotedProposal();
+    await govActionDetailsPage.vote(faker.lorem.sentence(200), true);
+
+    await govActionDetailsPage.currentPage.reload();
+
+    await governanceActionsPage.votedTab.click();
+
+    const isYesVoteVisible = await govActionDetailsPage.currentPage
+      .getByTestId("my-vote")
+      .getByText("Yes")
+      .isVisible();
+
+    const textContent = await govActionDetailsPage.currentPage
+      .getByTestId("my-vote")
+      .textContent();
+
+    await govActionDetailsPage.currentPage.evaluate(() =>
+      window.scrollTo(0, 500)
+    );
+    await expect(
+      govActionDetailsPage.currentPage.getByTestId("my-vote").getByText("No"),
+      {
+        message:
+          !isYesVoteVisible &&
+          `"Yes" vote not visible, current vote status: ${textContent.match(/My Vote:(Yes|No)/)[1]}`,
+      }
+    ).toBeVisible({ timeout: 60_000 });
+  });
+
   test("5I. Should view the vote details,when viewing governance action already voted by the DRep", async ({}, testInfo) => {
     test.setTimeout(testInfo.timeout + environments.txTimeOut);
 
@@ -233,7 +282,7 @@ test.describe("Perform voting", () => {
       govActionDetailsPage.currentPage
     );
 
-    await dRepPage.waitForTimeout(5_000);
+    await governanceActionsPage.currentPage.waitForTimeout(5_000);
 
     await governanceActionsPage.votedTab.click();
     await expect(