Skip to content

(feat#3745): support ed25519 author signature validation on gov actions#3801

Merged
Ciabas merged 1 commit intodevelopfrom
3745-display-authors-for-live-voting-governance-actions
Jun 20, 2025
Merged

(feat#3745): support ed25519 author signature validation on gov actions#3801
Ciabas merged 1 commit intodevelopfrom
3745-display-authors-for-live-voting-governance-actions

Conversation

@Ciabas
Copy link
Contributor

@Ciabas Ciabas commented Jun 17, 2025 •
edited
Loading

List of changes

  • Add support ed25519 author signature validation on gov actions

Checklist

  • related issue
  • [] My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Changes

image image image image

@Ciabas Ciabas requested a review from bosko-m June 17, 2025 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

✅ All checks succeeded

@bosko-m
Copy link
Contributor

bosko-m commented Jun 17, 2025

What does the gray box next to the authors name represent @Ciabas ? Third screenshot

@Ciabas
Copy link
Contributor Author

Ciabas commented Jun 17, 2025

@bosko-m It's a loading state that should be fast enough that no one notices it.

@bosko-m
Copy link
Contributor

bosko-m commented Jun 17, 2025

Understood, makes sense

@Ciabas Ciabas marked this pull request as ready for review June 18, 2025 08:40
@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners June 18, 2025 08:40
@Ciabas Ciabas marked this pull request as draft June 18, 2025 08:55
@Ciabas Ciabas force-pushed the 3745-display-authors-for-live-voting-governance-actions branch from b448b1d to f5ea89e Compare June 18, 2025 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

❌ Docker Image Scan (Dockle) failed

No output

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3745-display-authors-for-live-voting-governance-actions branch from f5ea89e to 0a2799c Compare June 18, 2025 13:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

✅ All checks succeeded

@Ciabas Ciabas force-pushed the 3745-display-authors-for-live-voting-governance-actions branch from 0a2799c to 1b45845 Compare June 20, 2025 08:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

@Ciabas
Copy link
Contributor Author

Ciabas commented Jun 20, 2025

@bosko-m I updated the icons and behaviour slightly to match with the other pillar.
image

@Ciabas Ciabas force-pushed the 3745-display-authors-for-live-voting-governance-actions branch from 1b45845 to 25584c4 Compare June 20, 2025 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

@Ciabas Ciabas marked this pull request as ready for review June 20, 2025 08:26
@Ciabas Ciabas requested a review from bosko-m June 20, 2025 08:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

✅ All checks succeeded

@Ciabas Ciabas merged commit 661580b into develop Jun 20, 2025
10 checks passed
@Ciabas Ciabas deleted the 3745-display-authors-for-live-voting-governance-actions branch June 20, 2025 08:50
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

@Ciabas
This PR is in the tag: develop-661580bcff18a14d830c84494d56b9ee13e2859b , for govtool-metadata-validation service

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

@Ciabas
This PR is in the tag: develop-661580bcff18a14d830c84494d56b9ee13e2859b , for govtool-backend service

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

@Ciabas
This PR is in the tag: develop-661580bcff18a14d830c84494d56b9ee13e2859b , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

1 more reviewer

@bosko-m bosko-m bosko-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ciabas @bosko-m