GDD: use new AF.splitAtSlot (#1231)

With #1207 merged, we can use `AF.splitAtSlot` which was introduced for
the use in the GDD by @facundominguez in
IntersectMBO/ouroboros-network#4884.

Author: amesgen

ouroboros-consensus/changelog.d/20240829_095937_alexander.esgen_gdd_splitAtSlot.md

@@ -0,0 +1,3 @@
+### Patch
+
+- Used new `AF.splitAtSlot` function in GDD.

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Genesis/Governor.hs

@@ -302,7 +302,8 @@ densityDisconnect (GenesisWindow sgen) (SecurityParam k) states candidateSuffixe
   where
     densityBounds = do
       (peer, candidateSuffix) <- candidateSuffixes
-      let clippedFragment = dropBeyondGenesisWindow candidateSuffix
+      let (clippedFragment, _) =
+            AF.splitAtSlot firstSlotAfterGenesisWindow candidateSuffix
       state <- maybeToList (states Map.!? peer)
       -- Skip peers that haven't sent any headers yet.
       -- They should be disconnected by timeouts instead.
@@ -400,11 +401,6 @@ densityDisconnect (GenesisWindow sgen) (SecurityParam k) states candidateSuffixe
     firstSlotAfterGenesisWindow =
         succWithOrigin loeIntersectionSlot + SlotNo sgen
 
-    -- This is performance sensitive. We used to call @takeWhileOldest@ here,
-    -- which would reconstruct much of the original fragment.
-    dropBeyondGenesisWindow =
-      AF.dropWhileNewest ((>= firstSlotAfterGenesisWindow) . blockSlot)
-
 -- Note [Chain disagreement]
 -- ~~~~~~~~~~~~~~~~~~~~~~~~~
 --