Add NTN CDDLs #1422
Merged
Add NTN CDDLs #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! See cardano-scaling/cardano-blueprint#25 for an issue that aims to use these to create an api reference. |
7 tasks
ch1bo
reviewed
Mar 27, 2025
ouroboros-consensus-cardano/cddl/node-to-client/localstatequery/query.cddl
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/cddl/node-to-client/localstatequery/consensus/getInterpreter.cddl
Outdated
Show resolved
Hide resolved
ch1bo
requested changes
Mar 27, 2025
ouroboros-consensus-cardano/cddl/node-to-client/localstatequery/consensus/getSystemStart.cddl
Outdated
Show resolved
Hide resolved
coot
reviewed
Mar 31, 2025
ch1bo
reviewed
May 7, 2025
jasagredo
force-pushed
the
js/cddls
branch
3 times, most recently
from
aafadd5 to
690e912
Compare
jasagredo
force-pushed
the
js/cddls
branch
2 times, most recently
from
4ede539 to
0e37093
Compare
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a,
jorisdral and
nfrisby
as code owners
|
This PR is blocked on IntersectMBO/cardano-ledger#5056 so that we can integrate a newer ledger that contains: |
jasagredo
force-pushed
the
js/delete-deprecate-query
branch
from
4484a94 to
6728359
Compare
dnadales
approved these changes
Jun 17, 2025
jasagredo
force-pushed
the
js/cddls
branch
2 times, most recently
from
2ff860f to
9923c95
Compare
Co-authored-by: Georgy Lukyanov <[email protected]>
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the NTN cddls, which we check on CI that they are the same as in the blueprints.
Golden files are checked against CDDL too in the test-suite, and the machinery for doing it with roundtrip tests is also ready but we can't use it due to input-output-hk/cuddle#79