-
Notifications
You must be signed in to change notification settings - Fork 39
Add support for new ledger state query GetDRepDelegations in NodeToClientV_23 #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasagredo
wants to merge
13
commits into
main
Choose a base branch
from
js/ktorz/GetDRepDelegations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+243
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is blocked because it requires an integration of ouroboros-network latest main into consensus. |
The commit should be revised
- replace distinct_VBytes with distinct_bytes - alonzo and babbage CDDLs also need fixing up
4728551 to
f37288d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR wires in a new ledger state query that was recently added but never got properly wired in.
This PR requires IntersectMBO/ouroboros-network#5222 due to the nice dependency on the network version there 😬.
Note that I do expect some help getting this merged. The repository is complex to build, and I kindly refuse to use Nix. So if anything goes wrong with CI, I would appreciate a little nudge from the maintainers to getting this through. It's been living on a fork of mine for a while, yet I can't properly make this available to end users in Ogmios without "official" support for it in the node.
Thanks.