Merged
Conversation
3 tasks
coot
force-pushed
the
coot/tx-submission
branch
6 times, most recently
from
76c0d13 to
11d833b
Compare
This was referenced Sep 18, 2024
crocodile-dentist
force-pushed
the
coot/tx-submission
branch
2 times, most recently
from
772809e to
374a78a
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
374a78a to
388cc69
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
efbc13a to
7b8ec92
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
7b8ec92 to
22c71d5
Compare
coot
force-pushed
the
coot/tx-submission
branch
from
22c71d5 to
6a1bdd9
Compare
coot
force-pushed
the
coot/tx-submission
branch
2 times, most recently
from
974b98d to
a764ad1
Compare
coot
force-pushed
the
coot/tx-submission
branch
6 times, most recently
from
adae14f to
3258afe
Compare
karknu
reviewed
Mar 14, 2025
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound/State.hs
Outdated
Show resolved
Hide resolved
coot
force-pushed
the
coot/tx-submission
branch
from
3258afe to
1d40e61
Compare
* `ctrl-<addr>` - the control thread
(top level threads, e.g. [2], [3], etc..)
* `node-<addr>` - the main node thread
([2,1], [3,1], etc)
* `krnl-<addr>` - the kernel thread (block production)
Removed the `TurbulentCommands` generator.
When we are acknowledging txs we also choose tx-s to be submitted to the mempool. We shouldn't disregard all acknowledged tx-s when we find a first buffered one, instead we can ignore them since they were already successfully submitted to the mempool.
When there's nothing to acknowledge, we return `TxsToMempool`, thus we also should update the `toMempoolTxs` field.
All other fields are strict.
* send `getTxAdvSize` rather than `getTxSize` together with `getTxId`; * fixed properties in presence of wrongly sized txs, the conditions are much weeker; hance * generate much less wrongly sized txs.
* Fixed Show instance for TestAddress: Deriving via Quiet produces a string which is not syntactivly valid Haskell * Show instance for `NodeArgs`: added brackes where needed. * Imports which work when pasting examples (still some imports need to be added). Using `-Wno-unused-imports` though.
* removed `numTxIdsToRequest` (not used & wrong) * replaced repeated code with a new function `splitAcknowledgedTxIds` * added test for `splitAcknowledgedTxIds`
Pass requested txids with sizes to the `collectTxs` call.
The property is only satisfied if there are no transaction which advertise wrong size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a draft PR (work in progress) which introduces
tx-submissionlogic responsible for choosing from which peer to download a tx.Checklist
Quality
Maintenance
ouroboros-networkproject.