Skip to content

Comments

SRV implementation#5018

Merged
crocodile-dentist merged 18 commits intomainfrom
mwojtowicz/srv
Mar 10, 2025
Merged

SRV implementation#5018
crocodile-dentist merged 18 commits intomainfrom
mwojtowicz/srv

Conversation

@crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Dec 3, 2024 •
edited
Loading

Description

This change introduces support for DNS SRV record lookups. When a relay is associated via SRV record, a two step resolution is attempted to first identify the relevant domains from which to make a secondary lookup to obtain the final address. All lookups are early bound in the sense that only the domains with top priority (ie. with the lowest priority numeric value in the record) are considered, and afterwards a single domain is randomly sampled it is queried for the address. If the lookup fails it is not retried.

The tracing of dns lookups has been reworked. The tracing happens in the DNSActions's dnsLookupWithTTL function, and the corresponding constructors from eg. TraceLocalRootPeers (and for Public and Ledger types) have been removed. This simplifies the logic in localRootsPeersProvider, publicRootPeersProvider and resolveLedgerPeers functions since the lookup doesn't have to return additional information regarding the domain names which have been resolved, which is used in the testing framework. But the main impetus was to extend test coverage to include the lookup functionality, which previously was excluded as only a map lookup was performed by the mock. Also, the tracing of dns lookups can now be performed via a dedicated dns tracer, which must be plumbed from the top level.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist self-assigned this Dec 3, 2024
@crocodile-dentist crocodile-dentist requested a review from a team as a code owner December 3, 2024 10:31
@crocodile-dentist crocodile-dentist marked this pull request as draft December 3, 2024 10:32
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/srv branch 13 times, most recently from 34fd024 to 75341dc Compare December 10, 2024 10:33
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/srv branch 3 times, most recently from b3f0498 to 4649b5a Compare December 11, 2024 15:20
@coot coot mentioned this pull request Dec 11, 2024
Closed
@coot coot linked an issue Dec 11, 2024 that may be closed by this pull request
Add support for SRV records #2883
Closed
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/srv branch 6 times, most recently from 37c578d to 9718a9c Compare December 13, 2024 11:39
coot
coot reviewed Dec 13, 2024
View reviewed changes
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Mar 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 7, 2025
crocodile-dentist and others added 16 commits March 7, 2025 21:08
@crocodile-dentist
SRV implementation
d4fc20b 
The lookup mechanism was enhanced with a distinct
tracer, and now returns either errors, or a list
of peerAddr's with TTL. The raw IP's obtained
from the lookup are only traced.

Use SRV ttl

Don't resolve disabled services
@crocodile-dentist
rng seed for SRV dns lookups
dbd6ed5
@crocodile-dentist
Integrate SRV lookups with ledger peers
c668686
@crocodile-dentist
Integrate SRV lookups with local root peers
a3ad9d7
@crocodile-dentist
Integrate SRV lookups with public root peers
b33ecd9
@crocodile-dentist
Remove DomainAccessPoint
91da0e5
@crocodile-dentist
Add RelayAccessSRVDomain constructor to RelayAccessPoint type
046f434 
Update JSON instances and transplant CBOR instances from
RelayAccessPointCoded type, which will be removed in a
followup commit, to support LedgerPeerSnapshot type for
Genesis big ledger peers snapshot.
@crocodile-dentist
Bump LedgerPeerSnapshot version
a77055e 
Directly leverages JSON and CBOR instances for RelayAccessPoint
instead of RelayAccessPointCoded, which will be removed in a
followup commit. The upshot of this change is that all domain
names in the snapshot file will be keyed by 'address' instead
of 'domain', but other than that there is no change to it. What
we gain is less maintenance burden of those extra instances that
now can be dropped.
@crocodile-dentist
Removes RelayAccessPointCoded and associated instances
e6134bf
@crocodile-dentist
Bump LedgerPeerSnapshot tests for V2
bcf8568
@crocodile-dentist
Rework RelayAccessPoint round trip test
995ba30 
Tests round trip encoding, modulo fully qualified domain
names, which previously was the only distinct feature
of the RelayAccessPointCoded type which has been removed.
@crocodile-dentist @coot
PeerSelection test types and instances
fcef064 
Co-authored-by: coot <coot@coot.me>
@crocodile-dentist
PeerSelection test changes
3b8eda1
@crocodile-dentist
Testnet diffusion script generation refactor for SRV records
2d379ec 
Reorganizes generation of diffusion script to accomodate
mock DNS SRV lookups. The generation of DNS lookup map
is postponed to genDomainMapScript function, where it is convenient
to create followup lookup domains for relays tagged as
RelayAccessSRVDomain. So now the strategy is first to generate some
relays, and then adapt the DNS lookup map for a particular set of
choices.
This map was previously generated in the Arbitrary instance for
RelayAccessInfosWithDNS, so simultaneously with the relays,
which was not optimal for the present more sequential nature needed
to generate the testcase. The latter type  was therefore also
removed.
Previous RelayAccessInfos was renamed to TestnetRelayInfos and
augmented with some fields for convenience.
@crocodile-dentist
Testnet tests adaptations
44b0c31
@crocodile-dentist
Cleanup imports
2218acb
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/srv branch 2 times, most recently from f925945 to 899f1df Compare March 7, 2025 20:55
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 28b731c Mar 10, 2025
11 of 14 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/srv branch March 10, 2025 13:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

@bolt12 bolt12 bolt12 approved these changes

Assignees

@crocodile-dentist crocodile-dentist

Labels

DNS Issues / PRs related to DNS

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for SRV records

3 participants

@crocodile-dentist @coot @bolt12