Conversation
coot
force-pushed
the
coot/ledger-peers-cleanup
branch
from
f4032d4 to
37e0de3
Compare
bolt12
approved these changes
Mar 6, 2025
…Peers and LedgerPeers This removes a dependency between `RootPeersDNS` and `LedgerPeers`, which allows us to remove `LedgerPeers.Common` module: * moved `IsLedgerPeers` to `LedgerPeers.Type` module in `ouroboros-network-api`. Next to `IsBigLedgerPeer`; * moved `LedgerPeers` to `LedgerPeers` where it is used.
`PeerActionsDNS` is already exported via the `DNSActions` module.
coot
force-pushed
the
coot/ledger-peers-cleanup
branch
2 times, most recently
from
365a811 to
913c757
Compare
coot
force-pushed
the
coot/ledger-peers-cleanup
branch
from
913c757 to
99da7ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes dependency between
LedgerPeersandRootPeersDNS.LedgerPeersmodules which allows us to remove the
LedgerPeers.Commonmodule.Checklist
Quality
Maintenance
ouroboros-networkproject.