-
Notifications
You must be signed in to change notification settings - Fork 90
Initial mini-protocols for Peras #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amesgen
wants to merge
5
commits into
main
Choose a base branch
from
peras-diffusion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2919ada to
05afd58
Compare
05afd58 to
e9d987e
Compare
agustinmista
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Oct 13, 2025
Bumps the external ouroboros-network source-repository-package to the updated peras-staging/pr-5202, which incorporates the changes from: IntersectMBO/ouroboros-network#5202 In addition, it tweak call sites of `nodeToNodeProtocols` to match its updated signature, passing down the enabled feature flags.
This was referenced Oct 13, 2025
agustinmista
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Oct 13, 2025
Bumps the external ouroboros-network source-repository-package to the updated peras-staging/pr-5202, which incorporates the changes from: IntersectMBO/ouroboros-network#5202 In addition, it tweak call sites of `nodeToNodeProtocols` to match its updated signature, passing down the enabled feature flags.
e9d987e to
0a82a45
Compare
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]> Co-authored-by: Nicolas "Niols" Jeannerod <[email protected]>
0a82a45 to
8ef5288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
NodeToNodeV_16for Peras, and depend onCardano.Base.FeatureFlagWe add a new (experimental)
NodeToNodeVersionfor Peras.Additionally, we add a function
which additionally checks that the
PerasFlagis set, cf IntersectMBO/cardano-base#547. Eventually, once Peras is non-experimental, thePerasFlagwill be removed again.nodeToNodeProtocolsnow depends onSet CardanoFeatureFlag.Add generic ObjectDiffusion mini-protocol
This protocol is going to be used for Peras vote and certificate diffusion. It is essentially a copy of TxSubmission, except that
MsgInitandMsgDoneare sent by the client/inbound side, as the flow of information is the reverse of that of TxSubmission.We also add codec roundtrip tests, but no CDDL just yet, given that we might make further changes to this protocol:
MsgInit: currently pointless, but will get a payload indicating that we are only interested in objects after some indicator.The representation of object ids currently always is a list of object ids. We are potentially going to make this customizable to optimize for cases where a more succinct representation is possible (such as requesting "ranges" of ids).
We might make some changes to how IDs are requested, such as allowing the server to reply with
MsgAwaitReplywhen we do a blocking request, cf Make idleness explicit in ObjectDiffusion mini-protocol tweag/cardano-peras#144.Register Peras vote and certificate diffusion mini-protocols
In
Cardano.Network.NodeToNode, make the Network layer aware of Peras certificate and vote diffusion, gated behind bothNodeToNodeV_16and the experimental Peras feature flag.Checklist
Quality
Maintenance
ouroboros-networkproject.