Skip to content

Derive NoThunks for NodeToNodeVersion #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

Derive NoThunks for NodeToNodeVersion #5214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-api/changelog.d/20251010_112341_agustin.mista_node_to_node_version_nothunks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Non-Breaking

- Added `NoThunks` instance for `NodeToNodeVersion`.

3 changes: 2 additions & 1 deletion ouroboros-network-api/src/Ouroboros/Network/NodeToNode/Version.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import Codec.CBOR.Term qualified as CBOR

import Control.DeepSeq
import GHC.Generics
import NoThunks.Class (NoThunks)
import Ouroboros.Network.CodecCBORTerm
import Ouroboros.Network.Handshake.Acceptable (Accept (..), Acceptable (..))
import Ouroboros.Network.Handshake.Queryable (Queryable (..))
Expand Down Expand Up @@ -70,7 +71,7 @@ data NodeToNodeVersion =
-- ^ Plomin HF, mandatory on mainnet as of 2025.01.29
| NodeToNodeV_15
-- ^ SRV support
deriving (Eq, Ord, Enum, Bounded, Show, Generic, NFData)
deriving (Eq, Ord, Enum, Bounded, Show, Generic, NFData, NoThunks)

nodeToNodeVersionCodec :: CodecCBORTerm (Text, Maybe Int) NodeToNodeVersion
nodeToNodeVersionCodec = CodecCBORTerm { encodeTerm, decodeTerm }
Expand Down