Skip to content

add NodeToClientV_23 -> GetDRepsDelegations #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
+9 −3
Merged

add NodeToClientV_23 -> GetDRepsDelegations #5222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cardano-diffusion/api/lib/Cardano/Network/NodeToClient/Version.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ data NodeToClientVersion
-- ^ new codecs for @PParams@ and @CompactGenesis@
| NodeToClientV_22
-- ^ support SRV records in @GetBigLedgerPeerSnapshot@ query
| NodeToClientV_23
-- ^ added @QueryDRepsDelegations@,
deriving (Eq, Ord, Enum, Bounded, Show, Generic, NFData)

-- | We set 16ths bit to distinguish `NodeToNodeVersion` and
Expand All @@ -76,6 +78,7 @@ nodeToClientVersionCodec = CodecCBORTerm { encodeTerm, decodeTerm }
NodeToClientV_20 -> enc 20
NodeToClientV_21 -> enc 21
NodeToClientV_22 -> enc 22
NodeToClientV_23 -> enc 23
where
enc :: Int -> CBOR.Term
enc = CBOR.TInt . (`setBit` nodeToClientVersionBit)
Expand All @@ -89,6 +92,7 @@ nodeToClientVersionCodec = CodecCBORTerm { encodeTerm, decodeTerm }
20 -> Right NodeToClientV_20
21 -> Right NodeToClientV_21
22 -> Right NodeToClientV_22
23 -> Right NodeToClientV_23
n -> Left (unknownTag n)
where
dec :: CBOR.Term -> Either (Text, Maybe Int) Int
Expand Down
2 changes: 2 additions & 0 deletions cardano-diffusion/orphan-instances/Cardano/Network/OrphanInstances.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ instance FromJSON NodeToClientVersion where
Number 20 -> pure NodeToClientV_20
Number 21 -> pure NodeToClientV_21
Number 22 -> pure NodeToClientV_22
Number 23 -> pure NodeToClientV_23
Number x -> fail $ "FromJSON.NodeToClientVersion: unsupported node-to-client protocol version " ++ show x
x -> fail $ "FromJSON.NodeToClientVersion: error parsing NodeToClientVersion: " ++ show x

Expand All @@ -95,6 +96,7 @@ instance ToJSON NodeToClientVersion where
NodeToClientV_20 -> Number 20
NodeToClientV_21 -> Number 21
NodeToClientV_22 -> Number 22
NodeToClientV_23 -> Number 23

instance ToJSON NodeToNodeVersionData where
toJSON (NodeToNodeVersionData (NetworkMagic m) dm ps q) = object
Expand Down
6 changes: 3 additions & 3 deletions cardano-diffusion/protocols/cddl/specs/handshake-node-to-client.cddl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ versionTable = { * versionNumber => nodeToClientVersionData }


; as of version 2 (which is no longer supported) we set 16th bit to 1
; 16 / 17 / 18 / 19 / 20 / 21 / 22
versionNumber = 32784 / 32785 / 32786 / 32787 / 32788 / 32789 / 32790
; 16 / 17 / 18 / 19 / 20 / 21 / 22 / 23
versionNumber = 32784 / 32785 / 32786 / 32787 / 32788 / 32789 / 32790 / 32791

; As of version 15 and higher
nodeToClientVersionData = [networkMagic, query]

networkMagic = uint
networkMagic = uint
query = bool

refuseReason
Expand Down
Loading