Conversation
7f777b7 to
06e2907
Compare
06e2907 to
dd6ae25
Compare
crocodile-dentist
approved these changes
Feb 9, 2026
Contributor
crocodile-dentist
left a comment
There was a problem hiding this comment.
One minor comment, and I prefer my slightly more direct and shorter setup on mw/coot/leios-network-mux-demo take a look and see if you want to paste the relevant bits into this PR.
| sudo tc -n ns$i qdisc del dev veth${i} root | ||
| sudo tc -n ns$i qdisc add dev veth${i} root handle 1: htb default 10 | ||
| sudo tc -n ns$i class add dev veth${i} parent 1: classid 1:1 htb rate $THROUPUT ceil $THROUPUT | ||
| sudo tc -n ns$i class add dev veth${i} parent 1:1 classid 1:10 htb rate $THROUPUT ceil $THROUPUT |
Contributor
There was a problem hiding this comment.
Do we need to add another one as classid 1:10 - we can directly attach fq_codel under 1:1 no?
Collaborator
Author
There was a problem hiding this comment.
If you post evidence that it works, I'm fine with it. I tested the approach in this PR, but I didn't succeed in making it simpler; maybe I wasn't persistent enough.
Collaborator
Author
There was a problem hiding this comment.
@crocodile-dentist I'm merging it as is, feel free to create a PR to modify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed egress shaping in mux-leios-demo and improved documentation.
Checklist
Quality
Maintenance
ouroboros-networkproject.