[Builtin] Add "dumb" Data matching
#7209
Open
+194
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '65c6e4d795' (base) and '5aa6ceb229' (PR) Results table
|
SeungheonOh
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
reviewed
Aug 21, 2025
There was a problem hiding this comment.
This all is well-implemented, but I believe we shouldn't do it.
We had a discussion with Philip DiSarro on Slack. My question to him was
I'm asking because if
chooseDataisn't particularly useful, then neithercaseDatawill be and so instead of worrying about the latter I should just implement proper casing onDatausing theCaseconstructor of the AST
And his answer was
Yes that would be much more impactful from my perspective.
He also said
Either way, this is a very small edge case relative to unwrapping expected constructor.
chooseDatais rarely ever used.
Basically, if chooseData is rarely ever used and people just unwrap the expected constructor (I, List etc), then casing on Data like implemented here isn't very useful and so we should do the more useful alternative of casing on Constr specifically to mimic the behavior of SOPs and approximate their efficiency, which is something that is definitely going to be used a lot on the chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6602
Here we don't do any elaborate casing on
Constrconstructor ofData; instead, it will simply case on each constructors ofData. This might not be useful since this style of casing isn't used frequently in real-world script.Feel free to close this PR, once we have smarter/more useful casing on Constr.