Use Data backed ledger types for COOP #7235
Open
+98
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungheonOh
commented
Jul 24, 2025
| Memory: 3_572_506 | ||
| Term Size: 4_267 | ||
| Flat Size: 10_061 | ||
| CPU: 1_189_413_270 |
SeungheonOh
commented
Jul 24, 2025
| An error has occurred: | ||
| The machine terminated because of an error, either from a built-in function or from an explicit use of 'error'. | ||
| Caused by: error |
There was a problem hiding this comment.
No clue why this is. No script logic was changed. 🫠
|
| @@ -210,7 +204,7 @@ authMp' | |||
| "Must mint at least one $AUTH token:\n" | |||
| <> "Must have a specified CurrencySymbol in the Value" | |||
| Just tokenNameMap -> | |||
| case AssocMap.toList tokenNameMap of | |||
| case AssocMap.toSOPList tokenNameMap of | |||
There was a problem hiding this comment.
This may be one of the reasons there is a performance decrease. Data.AssocMap.toSOPList has to traverse the whole map, while the AssocMap.toList doesn't have any runtime cost. Can you avoid using toSOPList here?
Comment on lines
+728
to
+733
| Value . AssocMap.safeFromSOPList . Map.toList . (AssocMap.safeFromSOPList . Map.toList <$>) $ | ||
| Map.unionsWith | ||
| (Map.unionWith (+)) | ||
| ( [ Map.singleton cs (Map.singleton tn q) | ||
| | (cs, tokens) <- AssocMap.toList . getValue $ v | ||
| , (tn, q) <- AssocMap.toList tokens | ||
| | (cs, tokens) <- AssocMap.toSOPList . getValue $ v | ||
| , (tn, q) <- AssocMap.toSOPList tokens |
There was a problem hiding this comment.
Again, Data <-> SOP conversions are expensive. Can this be avoided here? You won't be able to use the list comprehension, unfortunately, but there should be a way to write this code using builtins. Let me know if you need help with this and we can take a look together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes COOP to use Data backed ledger types.
Some scripts have reduced cost, some increased(!!). This is probably because how scripts are written originally; original scripts pass around many un-deconstructed data and deconstruct those when needed, perhaps this is very expensive here.
@zliu41 Turns out
RecordWildCardsworks perfectly fine with datatypes defined withasData. I was just being delusional.