Fix SQL Injection Vulnerabilities in 7 Adapters and PII Logic (Issue #216) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed SQL injection vulnerabilities in multiple database adapters (
PostgresAdapter,DatabricksAdapter,SQLServerAdapter,SnowflakeAdapter,OracleAdapter,MariaDBAdapter,BigQueryAdapter) and resolved hardcoded PII logic inDataProduct(Issue #216).Type of Change
Related Issue(s)
Fixes #216
Changes Made
sqlglot(andexp.to_table) across 7 adapters to prevent SQL injection.DataProduct.get_all_field_detailsto dynamically setis_pii=Truewhen "PII" is present in column tags (previously hardcoded toFalse).tests/security/test_adapter_security.pywith regression tests for all fixed adapters.Testing
Test Configuration
Test Cases
Test Commands
Checklist
Documentation Updates
Breaking Changes
Performance Impact