-
-
Notifications
You must be signed in to change notification settings - Fork 7
Update dependency electron to v18 [SECURITY] #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/npm-electron-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66532af to
82d7b4b
Compare
82d7b4b to
ef4121c
Compare
ef4121c to
77dc356
Compare
77dc356 to
a087d32
Compare
a087d32 to
352c862
Compare
352c862 to
17ac64d
Compare
17ac64d to
0057640
Compare
0057640 to
b9ae504
Compare
b9ae504 to
70a06da
Compare
70a06da to
c1f1271
Compare
c1f1271 to
0f34aef
Compare
0f34aef to
74a4004
Compare
74a4004 to
7c910d2
Compare
7c910d2 to
b0b79c6
Compare
b0b79c6 to
d833be6
Compare
d833be6 to
2192a63
Compare
2192a63 to
2ed7183
Compare
2ed7183 to
c40f9ab
Compare
c40f9ab to
03c4000
Compare
03c4000 to
f1a1c12
Compare
f1a1c12 to
70885e4
Compare
70885e4 to
976d1b1
Compare
976d1b1 to
b7a52f0
Compare
b7a52f0 to
02b1dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.0.13->^18.0.0GitHub Vulnerability Alerts
CVE-2020-15096
Impact
Apps using
contextIsolationare affected.This is a context isolation bypass, meaning that code running in the main world context in the renderer can reach into the isolated Electron context and perform privileged actions.
Workarounds
There are no app-side workarounds, you must update your Electron version to be protected.
Fixed Versions
9.0.0-beta.218.2.47.2.46.1.11For more information
If you have any questions or comments about this advisory:
CVE-2020-4075
Impact
The vulnerability allows arbitrary local file read by defining unsafe window options on a child window opened via window.open.
Workarounds
Ensure you are calling
event.preventDefault()on allnew-windowevents where theurloroptionsis not something you expect.Fixed Versions
9.0.0-beta.218.2.47.2.4For more information
If you have any questions or comments about this advisory:
CVE-2020-4077
Impact
Apps using both
contextIsolationandcontextBridgeare affected.This is a context isolation bypass, meaning that code running in the main world context in the renderer can reach into the isolated Electron context and perform privileged actions.
Workarounds
There are no app-side workarounds, you must update your Electron version to be protected.
Fixed Versions
9.0.0-beta.218.2.47.2.4For more information
If you have any questions or comments about this advisory:
CVE-2020-4076
Impact
Apps using
contextIsolationare affected.This is a context isolation bypass, meaning that code running in the main world context in the renderer can reach into the isolated Electron context and perform privileged actions.
Workarounds
There are no app-side workarounds, you must update your Electron version to be protected.
Fixed Versions
9.0.0-beta.218.2.47.2.4Non-Impacted Versions
9.0.0-beta.*For more information
If you have any questions or comments about this advisory:
CVE-2021-39184
Impact
This vulnerability allows a sandboxed renderer to request a "thumbnail" image of an arbitrary file on the user's system. The thumbnail can potentially include significant parts of the original file, including textual data in many cases.
All current stable versions of Electron are affected.
Patches
This was fixed with #30728, and the following Electron versions contain the fix:
Workarounds
If your app enables
contextIsolation, this vulnerability is significantly more difficult for an attacker to exploit.Further, if your app does not depend on the
createThumbnailFromPathAPI, then you can simply disable the functionality. In the main process, before the 'ready' event:For more information
If you have any questions or comments about this advisory, email us at [email protected].
CVE-2022-29257
Impact
This vulnerability allows attackers who have control over a given apps update server / update storage to serve maliciously crafted update packages that pass the code signing validation check but contain malicious code in some components.
Please note that this kind of attack would require significant privileges in your own auto updating infrastructure and the ease of that attack entirely depends on your infrastructure security.
Patches
This has been patched and the following Electron versions contain the fix:
18.0.0-beta.617.2.016.2.015.5.0Workarounds
There are no workarounds for this issue, please update to a patched version of Electron.
For more information
If you have any questions or comments about this advisory, email us at [email protected]
CVE-2022-36077
Impact
When following a redirect, Electron delays a check for redirecting to file:// URLs from other schemes. The contents of the file is not available to the renderer following the redirect, but if the redirect target is a SMB URL such as
file://some.website.com/, then in some cases, Windows will connect to that server and attempt NTLM authentication, which can include sending hashed credentials.Patches
This issue has been fixed in all current stable versions of Electron. Specifically, these versions contain the fixes:
We recommend all apps upgrade to the latest stable version of Electron.
Workarounds
If upgrading isn't possible, this issue can be addressed without upgrading by preventing redirects to file:// URLs in the
WebContents.on('will-redirect')event, for all WebContents:For more information
If you have any questions or comments about this advisory, email us at [email protected].
Credit
Thanks to user @coolcoolnoworries for reporting this issue.
Release Notes
electron/electron
v18.3.7: electron v18.3.7Compare Source
Release Notes for v18.3.7
Fixes
webContents.getUserAgent()incorrectly returning an empty string unless previously set. #35130 (Also in 17, 19, 20)Other Changes
v18.3.6: electron v18.3.6Compare Source
Release Notes for v18.3.6
Fixes
BrowserWindow.setEnabled(). #34973 (Also in 19, 20)titleBarStyle. #34873 (Also in 17, 19, 20)BrowserWindow.setRepresentedFilenameon macOS withtitlebarStyle: 'hiddenInset'ortitlebarStyle: 'hidden'inadvertently moves the traffic light location. #34847 (Also in 19, 20)BrowserWindows opened from new links wouldn't properly load URLs. #34910 (Also in 19)BrowserViews on Windows. #33478 (Also in 16)Other Changes
1287804. #351021333333. #346891335054. #346871335458. #346851336014. #350041339844. #350021340335. #350001340654. #34998v18.3.5: electron v18.3.5Compare Source
Release Notes for v18.3.5
Fixes
crashReporter.start()on macOS. #34640 (Also in 17, 19, 20)setWindowOpenHandler()would crash if the callback threw an error. #34627 (Also in 19, 20)w.setWindowButtonVisibility(true)immediately after exiting fullscreen fails to show window buttons. #34673 (Also in 19, 20)Other Changes
setBounds. #34641 (Also in 19, 20)1228661. #345691306751. #345601314310. #345581316578. #345681317673. #345661318610. #345561321078. #34692v18.3.4: electron v18.3.4Compare Source
Release Notes for v18.3.4
Fixes
{ name: 'All Files', extensions: ['*'] }in thefiltersparam of open or save dialogs on Linux would disallow choosing files without an extension. #34518 (Also in 19, 20)Other Changes
1227995. #345621320024. #345541324864,1218100. #34534v18.3.3: electron v18.3.3Compare Source
Release Notes for v18.3.3
Fixes
v18.3.2: electron v18.3.2Compare Source
Release Notes for v18.3.2
Fixes
window.close()is called during a fullscreen transition. #34392 (Also in 17, 19, 20)Other Changes
v18.3.1: electron v18.3.1Compare Source
Release Notes for v18.3.1
Fixes
Other Changes
crash_reporter::Startunder theelectroncategory forcrash_reporter::Start(). #34325 (Also in 17, 19)v18.3.0: electron v18.3.0Compare Source
Release Notes for v18.3.0
Fixes
loadExtensionon an extension directory that's missing a manifest file. #34304 (Also in 16, 17, 19)event.preventDefaultwas called in eitherwill-resizeorwill-moveon Windows. #34284 (Also in 16, 17, 19)v18.2.4: electron v18.2.4Compare Source
Release Notes for v18.2.4
Fixes
node_cli_inspectfuse is disabled. #34180 (Also in 16, 17)Other Changes
v18.2.3: electron v18.2.3Compare Source
Release Notes for v18.2.3
Fixes
safeStorageon Linux. #34148 (Also in 19)v18.2.2: electron v18.2.2Compare Source
Release Notes for v18.2.2
Fixes
SetLoginItemSettings()could potentially cause network volumes to be incorrectly mounted. #34106 (Also in 17, 19)Other Changes
v18.2.0: electron v18.2.0Compare Source
Release Notes for v18.2.0
Features
Fixes
app.requestSingleInstanceLock()API where it would sometimes hang. #33778Other Changes
v18.1.0: electron v18.1.0Compare Source
Release Notes for v18.1.0
Features
systemPreferences.subscribe{Local|Workspace}Notificationto take anullvalue for theeventparameter. #33771Fixes
altis shown with accessibility features enabled. #33843 (Also in 19)Other Changes
v18.0.4: electron v18.0.4Compare Source
Release Notes for v18.0.4
Fixes
Escapekeyboard events would not be properly propagated to the parent window after entering fullscreen and then exiting it again on Windows. #33787shell.openExternal()now reports more detailed errors on Windows. #33659 (Also in 15, 16, 17, 19)shell.openExternal()now reports more detailed errors on Windows. #33705 (Also in 15, 16, 17, 19)Other Changes
v18.0.3: electron v18.0.3Compare Source
Release Notes for v18.0.3
Other Changes
v18.0.2: electron v18.0.2Compare Source
Release Notes for v18.0.2
Fixes
Browser.getFocusedWindow()when child windows are closed. #33538 (Also in 17)BrowserWindow.unmaximizewas called on a window whose user bounds were maximized. #33550 (Also in 16, 17)app.requestSingleInstanceLock()when setting non-existent user data folder. #33592 (Also in 16, 17, 19)v18.0.1: electron v18.0.1Compare Source
Release Notes for v18.0.1
Fixes
Other Changes
v18.0.0: electron v18.0.0Compare Source
Release Notes for v18.0.0
Stack Upgrades
Breaking Changes
BrowserWindowProxy-based implementation ofwindow.open. This also removes thenativeWindowOpenoption fromwebPreferences. #29405Features
Additions
WebContents. #25873BrowserWindowmethod to change the button color, symbol color, and height of a window with WCO enabled. #33440nativeTheme.inForcedColorsModeAPI to allow detecting forced color mode. #33357 (Also in 15, 16, 17)showSubstitutions,toggleSmartQuotes,toggleSmartDashes,toggleTextReplacement. #32024first-instance-ackevent to theapp.requestSingleInstanceLock()flow, so that users can pass some data back from the second instance to the first instance. #31460heightoption for Windows Control Overlay. #31222 (Also in 15, 16, 17)ses.setCodeCachePath()API for setting code cache directory. #33286 (Also in 17)setBackgroundColor. #33364Fixes
BrowserWindow.fromWebContentswould returnundefinedduring thebrowser-window-createdevent. #33316setBoundswas not correctly applied if the user was moving or resizing the window concurrently on Windows. #33375Also in earlier versions....
npm_config_arch. #32266 (Also in 15, 16, 17)showSaveDialogSync()code path has been fixed. (Fixes #31997). #32049 (Also in 14, 15, 16, 17)maxWidthnot working in BrowserWindow constructor options. #32628 (Also in 17)window.opennot overriding parent'swebPreferences. #32057 (Also in 15, 16, 17)window.print(), the print button in the PDF viewer, or withBrowserWindow.webContents()and clicked cancel in the resulting print dialog. #32632 (Also in 17)BrowserViews. #31863 (Also in 14, 15, 16, 17)alert()dialog title is corrupted. #32434 (Also in 14, 15, 16, 17)alternateImages did not work properly on macOS. #33107 (Also in 15, 16, 17)ipcRenderer.postMessagewould throw errors when thetransferargument was not passed. #32433 (Also in 14, 15, 16, 17)webContents.openDevTools({ mode })did not work for certain dock positions. #32946 (Also in 17)webContents.savePagefailed when passing a relative path instead of an absolute one. #33019 (Also in 15, 16, 17)backgroundColorwas set toundefined, vibrancy failed to work and thebackgroundColorwould show up as white. #32517 (Also in 16, 17)maxHeightormaxWidthmade it so the width and height could no longer be resized. #33119 (Also in 17)maximizeandunmaximizeevents on Windows. #32643 (Also in 17)webContents.setZoomFactor(1.0). #32604 (Also in 13, 14, 15, 16, 17)skipTransformProcessTypeoption parsing inwin.setVisibleOnAllWorkspaces(). #32364 (Also in 13, 14, 15, 16, 17)session.setDevicePermissionHandler. #32651 (Also in 17)desktopCapturer.getSources. #32052 (Also in 16, 17)