-
Notifications
You must be signed in to change notification settings - Fork 6
Fix wkhtmltopdf build failure with graceful degradation #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…orkflow update Co-authored-by: nielsdrost7 <[email protected]>
Co-authored-by: nielsdrost7 <[email protected]>
nielsdrost7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot why can't wkhtmltopdf require libssl3 (?)
Is wkhtmltopdf required to run snappy PDF in Laravel
Why wkhtmltopdf can't use libssl3: Is wkhtmltopdf required for Laravel Snappy: The fix allows builds to continue when wkhtmltopdf installation fails, and disables it in CI where it's not needed for testing the Docker images themselves. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
nielsdrost7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot a fun and tough question:
I'm building InvoicePlane v2 with a report builder that Constructs a file to create a PDF from for Reports and Invoices.
I need and want the best solution.
My belief was that it would have been Snappy, although no wonder that Snappy is a wrapper around wkhtmltopdf.
In InvoicePlane v1 we're using mpdf.
I don't mind supplying both, I just don't want any more failing Docker builds
nielsdrost7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot a fun and tough question:
I'm building InvoicePlane v2 with a report builder that Constructs a file to create a PDF from for Reports and Invoices.
I need and want the best solution.
My belief was that it would have been Snappy, although no wonder that Snappy is a wrapper around wkhtmltopdf.
In InvoicePlane v1 we're using mpdf.
I don't mind supplying both, I just don't want any more failing Docker builds
For PDF generation in InvoicePlane v2, you have solid options: mpdf (pure PHP):
Snappy/wkhtmltopdf:
Recommendation: Start with mpdf (reliable, no build failures). Add wkhtmltopdf as an optional enhancement later if needed. The Docker setup now supports both—wkhtmltopdf won't break builds anymore, and mpdf requires no additional setup. Your builds are safe either way with the current fix. |
The wkhtmltopdf package requires
libssl1.1, which is unavailable in Ubuntu Noble 24.04+ (uses libssl3), causing Docker builds to fail with dependency errors.Changes
.docker/workspace/Dockerfile: Wrap wkhtmltopdf installation in error handler to allow build continuation on failureCI workflows: Disable wkhtmltopdf installation in
docker-build-test.ymlandtest-containers.ymlto prevent CI failuressed -i "s/WORKSPACE_INSTALL_WKHTMLTOPDF=true/WORKSPACE_INSTALL_WKHTMLTOPDF=false/" .env.dockerUsers can still enable wkhtmltopdf manually, but builds no longer fail when dependencies are unavailable.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.