Address code review feedback: fix shell injection, remove dead code, improve error handling

[Copilot]

Addresses security issues, code quality concerns, and reliability improvements identified in code review.

Security

Shell Injection in docker-exec.sh

• Added set +e around docker exec to properly capture exit codes with errexit enabled
• Note: Command injection vulnerability flagged in review remains unaddressed (requires parameter validation/escaping)

Redis Authentication

• Added password extraction and -a flag to all redis-cli commands in test workflow

Reliability

Error Handling

• Removed || true from Python3 installation block - critical failures now surface
• Added Xdebug installation verification with warning message
• Removed deprecated Python 2.7 installation entirely

User Creation Logic

• Simplified to avoid renaming existing system users
• Proper fallback chain: try PGID → use default GID → verify user exists

# Before: fragile rename chain with multiple fallbacks
(usermod -l ivpldock ubuntu && usermod -d /home/ivpldock -m ivpldock && ... || useradd -l ...)

# After: explicit checks, no renames
if ! id -u ivpldock > /dev/null 2>&1; then
    useradd -u ${PUID} -g ivpldock -m ivpldock -G docker_env;
else
    usermod -aG docker_env ivpldock;
fi

Workflow Robustness

• Changed sed patterns from hardcoded values to .* wildcards (docker-build-test.yml)
• Resilient to future default value changes

Code Quality

Removed Dead Code

• Deleted unused show_info_box() function in banner script
• Removed no-op sed commands in Dockerfile.74 and Dockerfile.81

Fixed Bugs

• Banner script: replaced literal \w with $(pwd) expansion
• .env.example: Added PHP 8.4 to accepted values comment
• Created missing php8.4.ini configuration file

Documentation

• Clarified .env.docker should be in .gitignore, not committed
• Explicit guidance: use .env.example as template

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}