-
Notifications
You must be signed in to change notification settings - Fork 3
Fix PHPStan type safety errors in test files #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: nielsdrost7 <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
PHPStan identified 3 type safety issues in test files: missing attribute imports and ambiguous factory return type.
Changes
DateFieldAutoPopulationTest.php- Added explicit type annotation for factory return to disambiguateNumberingmodel fromCollection:DateHelpersTest.phpandSendInvoiceToPeppolActionTest.php- Added missinguse PHPUnit\Framework\Attributes\Group;import for#[Group('failed')]attribute usage💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.