Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 1, 2026

  • Consolidate duplicate documentation files (move root-level docs to .github/)
    • Move PEPPOL_ARCHITECTURE.md to .github/
    • Move PEPPOL_TESTS_SUMMARY.md to .github/
    • Move TEST_GENERATION_SUMMARY.md to .github/
    • Move RUNNING_TESTS.md to .github/
    • Remove duplicate CHECKLIST.md from root
    • Update all internal links in README.md
  • Consolidate GitHub Actions workflows with Composer caching
    • Create reusable composite action for PHP setup with Composer caching
    • Update phpunit.yml to use composite action
    • Update phpstan.yml to use composite action
    • Update pint.yml to use composite action
    • Update composer-update.yml to use composite action
    • Update yarn-update.yml to use composite action
    • Update quickstart.yml to use composite action
    • Add Composer caching to release.yml
    • Document composite action in workflows README
    • Improve parameter descriptions for clarity
    • Clarify release.yml doesn't use composite action
  • Configure PHPUnit for smoke tests
    • Create phpunit.smoke.xml for smoke test execution
    • Update RUNNING_TESTS.md with comprehensive test documentation
    • Document smoke test groups and usage
    • Clarify ParaTest installation instructions
    • Fix relative links in RUNNING_TESTS.md
  • Add smoke tests to composer-update workflow
    • Enable smoke tests after dependency updates
    • Add proper environment setup for tests
    • Configure tests to continue on error
    • Document smoke test behavior in workflows README

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Update branch from develop to master Consolidate documentation and optimize CI with Composer caching Jan 1, 2026
Copilot AI requested a review from nielsdrost7 January 1, 2026 04:54
@nielsdrost7 nielsdrost7 requested a review from Copilot January 1, 2026 05:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates scattered documentation into the .github/ directory, optimizes CI workflows with a reusable composite action for Composer caching, and adds smoke test configuration for faster validation. The changes reduce CI execution time by 6-10 seconds per workflow run through intelligent caching.

  • Moved 4 documentation files from root to .github/ for better organization
  • Created composite action .github/actions/setup-php-composer with Composer caching, applied to 6 workflows
  • Added phpunit.smoke.xml configuration to run smoke tests filtered by #[Group('smoke')] attribute (17 test files)

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
phpunit.smoke.xml New PHPUnit configuration for smoke tests with group filtering
RUNNING_TESTS.md Deleted from root (moved to .github/)
README.md Updated links to reflect documentation moved to .github/
CHECKLIST.md Deleted from root (moved to .github/)
.github/workflows/yarn-update.yml Replaced manual PHP/Composer setup with composite action
.github/workflows/release.yml Added Composer caching (manual, not using composite action)
.github/workflows/quickstart.yml Replaced manual PHP/Composer setup with composite action
.github/workflows/pint.yml Replaced manual PHP/Composer setup with composite action
.github/workflows/phpunit.yml Replaced manual PHP/Composer setup with composite action
.github/workflows/phpstan.yml Replaced manual PHP/Composer setup with composite action
.github/workflows/composer-update.yml Replaced manual setup with composite action, added smoke test execution
.github/workflows/README.md Added documentation for composite action and updated smoke test section
.github/actions/setup-php-composer/action.yml New reusable composite action for PHP setup with Composer caching
.github/TEST_GENERATION_SUMMARY.md Moved from root, documents PEPPOL test generation
.github/RUNNING_TESTS.md Moved from root with comprehensive rewrite covering all test types
.github/PEPPOL_TESTS_SUMMARY.md Moved from root, documents PEPPOL test coverage
.github/PEPPOL_ARCHITECTURE.md Moved from root, documents PEPPOL e-invoicing architecture

Comment on lines +26 to +32
**Used by:**
- `phpunit.yml` - Test execution
- `phpstan.yml` - Static analysis
- `pint.yml` - Code formatting
- `composer-update.yml` - Dependency updates
- `yarn-update.yml` - Frontend dependency updates
- `quickstart.yml` - Smoke tests
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that the composite action is "Used by" these workflows, but release.yml is not listed and it doesn't actually use the composite action - it only adds caching directly. Either release.yml should be updated to use the composite action, or this list is accurate and doesn't need changing. However, the PR description mentions "Added caching to release.yml" which confirms it doesn't use the composite action.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feedback was already addressed in commit 66af3e5. The note has been added on line 34 explaining that release.yml uses manual Composer caching instead of the composite action due to its custom production build flags (--no-dev).

@nielsdrost7
Copy link
Collaborator

@copilot apply changes based on the comments in this thread

Copy link
Contributor Author

Copilot AI commented Jan 1, 2026

@copilot apply changes based on the comments in this thread

Applied all review feedback in commit 66af3e5:

  1. Workflows README - Added clarification that release.yml uses manual caching instead of the composite action
  2. Composite action - Improved parameter descriptions for composer-flags and composer-args to be clearer about behavior
  3. RUNNING_TESTS.md - Fixed relative links to CONTRIBUTING.md, TEST_GENERATION_SUMMARY.md, and PEPPOL_TESTS_SUMMARY.md (removed .github/ prefix since all files are in the same directory)

Comment on lines +26 to +32
**Used by:**
- `phpunit.yml` - Test execution
- `phpstan.yml` - Static analysis
- `pint.yml` - Code formatting
- `composer-update.yml` - Dependency updates
- `yarn-update.yml` - Frontend dependency updates
- `quickstart.yml` - Smoke tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copilot AI requested a review from nielsdrost7 January 1, 2026 05:46
@nielsdrost7 nielsdrost7 marked this pull request as ready for review January 1, 2026 05:52
@nielsdrost7 nielsdrost7 merged commit e0e28d7 into develop Jan 1, 2026
2 checks passed
@nielsdrost7 nielsdrost7 deleted the copilot/sub-pr-282-again branch January 1, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants